Title: [236920] trunk/Source/WebInspectorUI
- Revision
- 236920
- Author
- [email protected]
- Date
- 2018-10-08 10:17:21 -0700 (Mon, 08 Oct 2018)
Log Message
Web Inspector: be more specific as to what types of WI.Collection are allowed for the Resources tab
https://bugs.webkit.org/show_bug.cgi?id=190304
Reviewed by Brian Burg.
* UserInterface/Base/Main.js:
(WI.tabContentViewClassForRepresentedObject):
* UserInterface/Views/ResourcesTabContentView.js:
(WI.ResourcesTabContentView.prototype.canShowRepresentedObject):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236919 => 236920)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:16:30 UTC (rev 236919)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-08 17:17:21 UTC (rev 236920)
@@ -1,5 +1,17 @@
2018-10-08 Devin Rousso <[email protected]>
+ Web Inspector: be more specific as to what types of WI.Collection are allowed for the Resources tab
+ https://bugs.webkit.org/show_bug.cgi?id=190304
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Base/Main.js:
+ (WI.tabContentViewClassForRepresentedObject):
+ * UserInterface/Views/ResourcesTabContentView.js:
+ (WI.ResourcesTabContentView.prototype.canShowRepresentedObject):
+
+2018-10-08 Devin Rousso <[email protected]>
+
Web Inspector: Open Resource Dialog should show path to resource (to disambiguate resources with same name)
https://bugs.webkit.org/show_bug.cgi?id=178153
<rdar://problem/34925686>
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (236919 => 236920)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-10-08 17:16:30 UTC (rev 236919)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-10-08 17:17:21 UTC (rev 236920)
@@ -1099,10 +1099,13 @@
}
if (representedObject instanceof WI.Frame
+ || representedObject instanceof WI.FrameCollection
|| representedObject instanceof WI.Resource
+ || representedObject instanceof WI.ResourceCollection
|| representedObject instanceof WI.Script
+ || representedObject instanceof WI.ScriptCollection
|| representedObject instanceof WI.CSSStyleSheet
- || (representedObject instanceof WI.Collection && !(representedObject instanceof WI.CanvasCollection)))
+ || representedObject instanceof WI.CSSStyleSheetCollection)
return WI.ResourcesTabContentView;
if (representedObject instanceof WI.DOMStorageObject || representedObject instanceof WI.CookieStorageObject ||
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js (236919 => 236920)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js 2018-10-08 17:16:30 UTC (rev 236919)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js 2018-10-08 17:17:21 UTC (rev 236920)
@@ -55,10 +55,13 @@
canShowRepresentedObject(representedObject)
{
return representedObject instanceof WI.Frame
+ || representedObject instanceof WI.FrameCollection
|| representedObject instanceof WI.Resource
+ || representedObject instanceof WI.ResourceCollection
|| representedObject instanceof WI.Script
+ || representedObject instanceof WI.ScriptCollection
|| representedObject instanceof WI.CSSStyleSheet
- || (representedObject instanceof WI.Collection && !(representedObject instanceof WI.CanvasCollection));
+ || representedObject instanceof WI.CSSStyleSheetCollection;
}
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
