[webkit-changes] [236962] trunk/Source/WTF

Tue, 09 Oct 2018 08:32:49 -0700

Title: [236962] trunk/Source/WTF
Revision
236962
Author
[email protected]
Date
2018-10-09 08:31:31 -0700 (Tue, 09 Oct 2018)

Log Message

Revert temporary asserts for debugging a mysterious ASAN bot crash.
https://bugs.webkit.org/show_bug.cgi?id=190396

Reviewed by Yusuke Suzuki.

* wtf/StackBounds.cpp:
(WTF::StackBounds::newThreadStackBounds):
* wtf/StackBounds.h:
(WTF::StackBounds::checkConsistency const):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (236961 => 236962)


--- trunk/Source/WTF/ChangeLog	2018-10-09 15:10:17 UTC (rev 236961)
+++ trunk/Source/WTF/ChangeLog	2018-10-09 15:31:31 UTC (rev 236962)
@@ -1,3 +1,15 @@
+2018-10-09  Mark Lam  <[email protected]>
+
+        Revert temporary asserts for debugging a mysterious ASAN bot crash.
+        https://bugs.webkit.org/show_bug.cgi?id=190396
+
+        Reviewed by Yusuke Suzuki.
+
+        * wtf/StackBounds.cpp:
+        (WTF::StackBounds::newThreadStackBounds):
+        * wtf/StackBounds.h:
+        (WTF::StackBounds::checkConsistency const):
+
 2018-10-08  Aditya Keerthi  <[email protected]>
 
         Make <input type=color> a runtime enabled (on-by-default) feature

Modified: trunk/Source/WTF/wtf/StackBounds.cpp (236961 => 236962)


--- trunk/Source/WTF/wtf/StackBounds.cpp	2018-10-09 15:10:17 UTC (rev 236961)
+++ trunk/Source/WTF/wtf/StackBounds.cpp	2018-10-09 15:31:31 UTC (rev 236962)
@@ -145,18 +145,6 @@
     if (stackDirection() == StackDirection::Upward)
         std::swap(origin, bound);
 
-    // The following set of assertions are only needed for debugging a
-    // mysterious crash on an ASAN bot that is not reproducible otherwise.
-    // Will remove after the needed data has been collected.
-#if OS(LINUX)
-    else {
-        ASSERT(stackDirection() == StackDirection::Downward);
-        void* currentPosition = &currentPosition;
-        ASSERT_WITH_MESSAGE_UNUSED(currentPosition, (currentPosition < origin && currentPosition > bound), "newThreadStackBounds: currentPosition %p origin %p bound %p stackSize %zu", currentPosition, origin, bound, stackSize);
-    }
-#endif
-    // End of ASAN bot debugging assertions.
-
     return StackBounds { origin, bound };
 }

Modified: trunk/Source/WTF/wtf/StackBounds.h (236961 => 236962)


--- trunk/Source/WTF/wtf/StackBounds.h	2018-10-09 15:10:17 UTC (rev 236961)
+++ trunk/Source/WTF/wtf/StackBounds.h	2018-10-09 15:31:31 UTC (rev 236962)
@@ -147,18 +147,6 @@
     {
 #if !ASSERT_DISABLED
         void* currentPosition = &currentPosition;
-
-        // The following set of assertions are only needed for debugging a
-        // mysterious crash on an ASAN bot that is not reproducible otherwise.
-        // Will remove after the needed data has been collected.
-#if OS(LINUX)
-        if (isGrowingDownward())
-            ASSERT_WITH_MESSAGE((currentPosition < m_origin && currentPosition > m_bound), "checkConsistency: currentPosition %p m_origin %p m_bound %p stackSize %zu", currentPosition, m_origin, m_bound, (reinterpret_cast<uint8_t*>(m_origin) - reinterpret_cast<uint8_t*>(m_bound)));
-        else
-            ASSERT_WITH_MESSAGE((currentPosition > m_origin && currentPosition < m_bound), "checkConsistency: currentPosition %p m_origin %p m_bound %p stackSize %zu", currentPosition, m_origin, m_bound, (reinterpret_cast<uint8_t*>(m_bound) - reinterpret_cast<uint8_t*>(m_origin)));
-#endif // OS(LINUX)
-        // End of ASAN bot debugging assertions.
-
         ASSERT(m_origin != m_bound);
         ASSERT(isGrowingDownward()
             ? (currentPosition < m_origin && currentPosition > m_bound)

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to