Title: [236977] branches/safari-606.2.104.0-branch
Revision
236977
Author
alanc...@apple.com
Date
2018-10-09 12:52:27 -0700 (Tue, 09 Oct 2018)

Log Message

Cherry-pick r236945. rdar://problem/45133492

    CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
    https://bugs.webkit.org/show_bug.cgi?id=190376
    <rdar://problem/44986520>

    Reviewed by Tim Horton.

    Source/WebCore:

    Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
    depth from 256 to 128.

    Modified existing test: compositing/layer-creation/deep-tree.html

    * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.

    LayoutTests:

    * compositing/layer-creation/deep-tree.html:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-606.2.104.0-branch/LayoutTests/ChangeLog (236976 => 236977)


--- branches/safari-606.2.104.0-branch/LayoutTests/ChangeLog	2018-10-09 19:32:41 UTC (rev 236976)
+++ branches/safari-606.2.104.0-branch/LayoutTests/ChangeLog	2018-10-09 19:52:27 UTC (rev 236977)
@@ -1,3 +1,38 @@
+2018-10-09  Kocsen Chung  <kocsen_ch...@apple.com>
+
+        Cherry-pick r236945. rdar://problem/45133492
+
+    CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+    https://bugs.webkit.org/show_bug.cgi?id=190376
+    <rdar://problem/44986520>
+    
+    Reviewed by Tim Horton.
+    
+    Source/WebCore:
+    
+    Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+    depth from 256 to 128.
+    
+    Modified existing test: compositing/layer-creation/deep-tree.html
+    
+    * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+    
+    LayoutTests:
+    
+    * compositing/layer-creation/deep-tree.html:
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-10-08  Dean Jackson  <d...@apple.com>
+
+            CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+            https://bugs.webkit.org/show_bug.cgi?id=190376
+            <rdar://problem/44986520>
+
+            Reviewed by Tim Horton.
+
+            * compositing/layer-creation/deep-tree.html:
+
 2018-09-28  Babak Shafiei  <bshaf...@apple.com>
 
         Cherry-pick r236615. rdar://problem/44883290

Modified: branches/safari-606.2.104.0-branch/LayoutTests/compositing/layer-creation/deep-tree.html (236976 => 236977)


--- branches/safari-606.2.104.0-branch/LayoutTests/compositing/layer-creation/deep-tree.html	2018-10-09 19:32:41 UTC (rev 236976)
+++ branches/safari-606.2.104.0-branch/LayoutTests/compositing/layer-creation/deep-tree.html	2018-10-09 19:52:27 UTC (rev 236977)
@@ -33,7 +33,7 @@
         
         function doTest()
         {
-            makeDeepTree(500, document.getElementById('deep'));
+            makeDeepTree(129, document.getElementById('deep'));
         }
         
         window.addEventListener('load', doTest, false);

Modified: branches/safari-606.2.104.0-branch/Source/WebCore/ChangeLog (236976 => 236977)


--- branches/safari-606.2.104.0-branch/Source/WebCore/ChangeLog	2018-10-09 19:32:41 UTC (rev 236976)
+++ branches/safari-606.2.104.0-branch/Source/WebCore/ChangeLog	2018-10-09 19:52:27 UTC (rev 236977)
@@ -1,3 +1,43 @@
+2018-10-09  Kocsen Chung  <kocsen_ch...@apple.com>
+
+        Cherry-pick r236945. rdar://problem/45133492
+
+    CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+    https://bugs.webkit.org/show_bug.cgi?id=190376
+    <rdar://problem/44986520>
+    
+    Reviewed by Tim Horton.
+    
+    Source/WebCore:
+    
+    Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+    depth from 256 to 128.
+    
+    Modified existing test: compositing/layer-creation/deep-tree.html
+    
+    * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+    
+    LayoutTests:
+    
+    * compositing/layer-creation/deep-tree.html:
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-10-08  Dean Jackson  <d...@apple.com>
+
+            CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+            https://bugs.webkit.org/show_bug.cgi?id=190376
+            <rdar://problem/44986520>
+
+            Reviewed by Tim Horton.
+
+            Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+            depth from 256 to 128.
+
+            Modified existing test: compositing/layer-creation/deep-tree.html
+
+            * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+
 2018-10-03  Kocsen Chung  <kocsen_ch...@apple.com>
 
         Cherry-pick r236806. rdar://problem/44855484

Modified: branches/safari-606.2.104.0-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (236976 => 236977)


--- branches/safari-606.2.104.0-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2018-10-09 19:32:41 UTC (rev 236976)
+++ branches/safari-606.2.104.0-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2018-10-09 19:52:27 UTC (rev 236977)
@@ -89,7 +89,7 @@
 #endif
 
 // Derived empirically: <rdar://problem/13401861>
-static const unsigned cMaxLayerTreeDepth = 250;
+static const unsigned cMaxLayerTreeDepth = 128;
 
 // About 10 screens of an iPhone 6 Plus. <rdar://problem/44532782>
 static const unsigned cMaxTotalBackdropFilterArea = 1242 * 2208 * 10;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to