Title: [237006] trunk/Source/WebInspectorUI
- Revision
- 237006
- Author
- [email protected]
- Date
- 2018-10-10 11:01:25 -0700 (Wed, 10 Oct 2018)
Log Message
Web Inspector: indent all network entries when "Group by Node" is checked
https://bugs.webkit.org/show_bug.cgi?id=190388
Reviewed by Timothy Hatcher.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateNameCell):
(WI.NetworkTableContentView.prototype._handleGroupByDOMNodeCheckedDidChange):
* UserInterface/Views/NetworkTableContentView.css:
(.network-table.grouped .data-container .cell.name): Added.
(.network-table.grouped .data-container .cell:not(.parent).name): Added.
(.network-table.grouped .data-container .cell.child.name): Added.
(.network-table .cell.grouped-by-node.name): Deleted.
(body[dir=ltr] .network-table .cell.grouped-by-node.name): Deleted.
(body[dir=rtl] .network-table .cell.grouped-by-node.name): Deleted.
Apply a padding to all nodes when the `WI.Table` is grouped.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (237005 => 237006)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-10 17:45:10 UTC (rev 237005)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-10 18:01:25 UTC (rev 237006)
@@ -1,3 +1,23 @@
+2018-10-10 Devin Rousso <[email protected]>
+
+ Web Inspector: indent all network entries when "Group by Node" is checked
+ https://bugs.webkit.org/show_bug.cgi?id=190388
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView.prototype._populateNameCell):
+ (WI.NetworkTableContentView.prototype._handleGroupByDOMNodeCheckedDidChange):
+
+ * UserInterface/Views/NetworkTableContentView.css:
+ (.network-table.grouped .data-container .cell.name): Added.
+ (.network-table.grouped .data-container .cell:not(.parent).name): Added.
+ (.network-table.grouped .data-container .cell.child.name): Added.
+ (.network-table .cell.grouped-by-node.name): Deleted.
+ (body[dir=ltr] .network-table .cell.grouped-by-node.name): Deleted.
+ (body[dir=rtl] .network-table .cell.grouped-by-node.name): Deleted.
+ Apply a padding to all nodes when the `WI.Table` is grouped.
+
2018-10-09 Devin Rousso <[email protected]>
Web Inspector: show redirect requests in Network and Timelines tabs
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css (237005 => 237006)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css 2018-10-10 17:45:10 UTC (rev 237005)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css 2018-10-10 18:01:25 UTC (rev 237006)
@@ -69,16 +69,17 @@
content: url(../Images/DisclosureTriangles.svg#open-selected);
}
-.network-table .cell.grouped-by-node.name {
+.network-table.grouped .data-container .cell.name {
--item-padding-start: 19px;
+ --item-disclosure-width: 11px;
}
-body[dir=ltr] .network-table .cell.grouped-by-node.name {
- padding-left: var(--item-padding-start);
+.network-table.grouped .data-container .cell:not(.parent).name {
+ -webkit-padding-start: var(--item-padding-start);
}
-body[dir=rtl] .network-table .cell.grouped-by-node.name {
- padding-right: var(--item-padding-start);
+.network-table.grouped .data-container .cell.child.name {
+ -webkit-padding-start: calc(var(--item-padding-start) + var(--item-disclosure-width));
}
.network-table li:not(.selected) .cell:matches(.cache-type, .multiple) {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (237005 => 237006)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2018-10-10 17:45:10 UTC (rev 237005)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2018-10-10 18:01:25 UTC (rev 237006)
@@ -481,6 +481,10 @@
let domNode = entry.domNode;
if (domNode) {
+ this._table.element.classList.add("grouped");
+
+ cell.classList.add("parent");
+
let disclosureElement = cell.appendChild(document.createElement("img"));
disclosureElement.classList.add("disclosure");
disclosureElement.classList.toggle("expanded", !!entry.expanded);
@@ -515,7 +519,7 @@
if (WI.settings.groupByDOMNode.value && resource.initiatorNode) {
let nodeEntry = this._domNodeEntries.get(resource.initiatorNode);
if (nodeEntry.initiatedResourceEntries.length > 1) {
- cell.classList.add("grouped-by-node");
+ cell.classList.add("child");
let range = resource.requestedByteRange;
if (range)
@@ -1620,6 +1624,9 @@
{
WI.settings.groupByDOMNode.value = this._groupByDOMNodeNavigationItem.checked;
+ if (!WI.settings.groupByDOMNode.value)
+ this._table.element.classList.remove("grouped");
+
this._updateSortAndFilteredEntries();
this._table.reloadData();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
