Title: [237015] trunk/Tools
Revision
237015
Author
[email protected]
Date
2018-10-10 13:29:01 -0700 (Wed, 10 Oct 2018)

Log Message

build-webkit --inspector-frontend shouldn't have a nonzero exit code
https://bugs.webkit.org/show_bug.cgi?id=190430

Reviewed by Brian Burg.

* Scripts/webkitdirs.pm:
(argumentsForConfiguration):
--inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (237014 => 237015)


--- trunk/Tools/ChangeLog	2018-10-10 20:06:05 UTC (rev 237014)
+++ trunk/Tools/ChangeLog	2018-10-10 20:29:01 UTC (rev 237015)
@@ -1,3 +1,15 @@
+2018-10-10  Ross Kirsling  <[email protected]>
+
+        build-webkit --inspector-frontend shouldn't have a nonzero exit code
+        https://bugs.webkit.org/show_bug.cgi?id=190430
+
+        Reviewed by Brian Burg.
+
+        * Scripts/webkitdirs.pm:
+        (argumentsForConfiguration):
+        --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
+        it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
+
 2018-10-10  Tim Horton  <[email protected]>
 
         Share more WKShareSheet code between macOS and iOS, and fix a few bugs

Modified: trunk/Tools/Scripts/webkitdirs.pm (237014 => 237015)


--- trunk/Tools/Scripts/webkitdirs.pm	2018-10-10 20:06:05 UTC (rev 237014)
+++ trunk/Tools/Scripts/webkitdirs.pm	2018-10-10 20:29:01 UTC (rev 237015)
@@ -494,7 +494,6 @@
     push(@args, '--wpe') if isWPE();
     push(@args, '--jsc-only') if isJSCOnly();
     push(@args, '--wincairo') if isWinCairo();
-    push(@args, '--inspector-frontend') if isInspectorFrontend();
     return @args;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to