Title: [237056] trunk/Source/WebKit
- Revision
- 237056
- Author
- [email protected]
- Date
- 2018-10-11 16:51:08 -0700 (Thu, 11 Oct 2018)
Log Message
iOS: Scrolling using the arrow keys doesn't show the scroll indicator like it does on macOS
https://bugs.webkit.org/show_bug.cgi?id=190478
<rdar://problem/22194031>
Reviewed by Megan Gardner.
* Platform/spi/ios/UIKitSPI.h:
Add some SPI.
* UIProcess/ios/WKKeyboardScrollingAnimator.mm:
(-[WKKeyboardScrollViewAnimator scrollToContentOffset:animated:]):
Do a persistent flash when scrolling continuously.
(-[WKKeyboardScrollViewAnimator scrollWithScrollToExtentAnimationTo:]):
Do a single flash when doing a scroll-to-top/bottom.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (237055 => 237056)
--- trunk/Source/WebKit/ChangeLog 2018-10-11 23:48:19 UTC (rev 237055)
+++ trunk/Source/WebKit/ChangeLog 2018-10-11 23:51:08 UTC (rev 237056)
@@ -1,5 +1,23 @@
2018-10-11 Tim Horton <[email protected]>
+ iOS: Scrolling using the arrow keys doesn't show the scroll indicator like it does on macOS
+ https://bugs.webkit.org/show_bug.cgi?id=190478
+ <rdar://problem/22194031>
+
+ Reviewed by Megan Gardner.
+
+ * Platform/spi/ios/UIKitSPI.h:
+ Add some SPI.
+
+ * UIProcess/ios/WKKeyboardScrollingAnimator.mm:
+ (-[WKKeyboardScrollViewAnimator scrollToContentOffset:animated:]):
+ Do a persistent flash when scrolling continuously.
+
+ (-[WKKeyboardScrollViewAnimator scrollWithScrollToExtentAnimationTo:]):
+ Do a single flash when doing a scroll-to-top/bottom.
+
+2018-10-11 Tim Horton <[email protected]>
+
Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
https://bugs.webkit.org/show_bug.cgi?id=190476
<rdar://problem/32757191>
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (237055 => 237056)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2018-10-11 23:48:19 UTC (rev 237055)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2018-10-11 23:51:08 UTC (rev 237056)
@@ -1038,6 +1038,7 @@
- (BOOL)_canScrollY;
- (void)_setContentOffsetWithDecelerationAnimation:(CGPoint)contentOffset;
- (CGPoint)_adjustedContentOffsetForContentOffset:(CGPoint)contentOffset;
+- (void)_flashScrollIndicatorsPersistingPreviousFlashes:(BOOL)persisting;
@end
@interface UIPeripheralHost (IPI)
Modified: trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm (237055 => 237056)
--- trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm 2018-10-11 23:48:19 UTC (rev 237055)
+++ trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm 2018-10-11 23:51:08 UTC (rev 237056)
@@ -553,6 +553,7 @@
if (_delegateRespondsToWillScroll)
[_delegate keyboardScrollViewAnimatorWillScroll:self];
[scrollView setContentOffset:contentOffsetDelta animated:animated];
+ [scrollView _flashScrollIndicatorsPersistingPreviousFlashes:YES];
}
- (void)scrollWithScrollToExtentAnimationTo:(CGPoint)offset
@@ -559,6 +560,7 @@
{
auto scrollView = _scrollView.getAutoreleased();
[scrollView _setContentOffsetWithDecelerationAnimation:offset];
+ [scrollView flashScrollIndicators];
}
- (CGPoint)contentOffset
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
