Title: [237090] trunk/Source/WebInspectorUI
- Revision
- 237090
- Author
- [email protected]
- Date
- 2018-10-12 16:52:09 -0700 (Fri, 12 Oct 2018)
Log Message
Web Inspector: Canvas: previews aren't removed when the parent view is hidden
https://bugs.webkit.org/show_bug.cgi?id=190525
Reviewed by Matt Baker.
* UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView.prototype.attached):
* UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager.prototype.get canvases):
(WI.CanvasManager.prototype.get shaderPrograms):
Drive-by: simplify these getters.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (237089 => 237090)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-12 23:27:45 UTC (rev 237089)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-12 23:52:09 UTC (rev 237090)
@@ -1,3 +1,18 @@
+2018-10-12 Devin Rousso <[email protected]>
+
+ Web Inspector: Canvas: previews aren't removed when the parent view is hidden
+ https://bugs.webkit.org/show_bug.cgi?id=190525
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/CanvasTabContentView.js:
+ (WI.CanvasTabContentView.prototype.attached):
+
+ * UserInterface/Controllers/CanvasManager.js:
+ (WI.CanvasManager.prototype.get canvases):
+ (WI.CanvasManager.prototype.get shaderPrograms):
+ Drive-by: simplify these getters.
+
2018-10-12 Joseph Pecoraro <[email protected]>
Web Inspector: Dark Mode: Highlight text in Network Headers search is too dark
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js (237089 => 237090)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js 2018-10-12 23:27:45 UTC (rev 237089)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js 2018-10-12 23:52:09 UTC (rev 237090)
@@ -42,12 +42,12 @@
get canvases()
{
- return [...this._canvasIdentifierMap.values()];
+ return Array.from(this._canvasIdentifierMap.values());
}
get shaderPrograms()
{
- return [...this._shaderProgramIdentifierMap.values()];
+ return Array.from(this._shaderProgramIdentifierMap.values());
}
importRecording()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js (237089 => 237090)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js 2018-10-12 23:27:45 UTC (rev 237089)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js 2018-10-12 23:52:09 UTC (rev 237090)
@@ -127,10 +127,10 @@
WI.canvasManager.addEventListener(WI.CanvasManager.Event.RecordingImported, this._recordingImportedOrStopped, this);
WI.Canvas.addEventListener(WI.Canvas.Event.RecordingStopped, this._recordingImportedOrStopped, this);
- let canvases = new Set([...this._canvasCollection, ...WI.canvasManager.canvases]);
+ let canvases = WI.canvasManager.canvases;
for (let canvas of this._canvasCollection) {
- if (!canvases.has(canvas))
+ if (!canvases.includes(canvas))
this._removeCanvas(canvas);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
