Title: [237166] trunk/Source/WebKit
- Revision
- 237166
- Author
- [email protected]
- Date
- 2018-10-15 18:04:37 -0700 (Mon, 15 Oct 2018)
Log Message
HSTS cache entries cannot be removed by origin
https://bugs.webkit.org/show_bug.cgi?id=190455
<rdar://problem/45181322>
Patch by Sihui Liu <[email protected]> on 2018-10-15
Reviewed by Chris Dumez.
The SPI _CFNetworkResetHSTS does not recognize url without protocol, so we need to add protocol manually.
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (237165 => 237166)
--- trunk/Source/WebKit/ChangeLog 2018-10-16 01:02:54 UTC (rev 237165)
+++ trunk/Source/WebKit/ChangeLog 2018-10-16 01:04:37 UTC (rev 237166)
@@ -1,3 +1,16 @@
+2018-10-15 Sihui Liu <[email protected]>
+
+ HSTS cache entries cannot be removed by origin
+ https://bugs.webkit.org/show_bug.cgi?id=190455
+ <rdar://problem/45181322>
+
+ Reviewed by Chris Dumez.
+
+ The SPI _CFNetworkResetHSTS does not recognize url without protocol, so we need to add protocol manually.
+
+ * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+ (WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
+
2018-10-15 Alex Christensen <[email protected]>
Fix GTK build, even though bots are not working right now.
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm (237165 => 237166)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2018-10-16 01:02:54 UTC (rev 237165)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2018-10-16 01:04:37 UTC (rev 237166)
@@ -161,8 +161,8 @@
void NetworkProcess::deleteHSTSCacheForHostNames(WebCore::NetworkStorageSession& session, const Vector<String>& hostNames)
{
for (auto& hostName : hostNames) {
- auto url = "" hostName.createCFString().get(), NULL));
- _CFNetworkResetHSTS(url.get(), session.platformSession());
+ auto url = "" }, makeString("https://", hostName));
+ _CFNetworkResetHSTS(url.createCFURL().get(), session.platformSession());
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
