Title: [101706] trunk/Source
- Revision
- 101706
- Author
- [email protected]
- Date
- 2011-12-01 14:16:10 -0800 (Thu, 01 Dec 2011)
Log Message
More void functions eager to return values in RenderObject & WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=73571
Reviewed by Adam Barth.
Source/WebCore:
* rendering/RenderObject.h:
(WebCore::RenderObject::computeAbsoluteRepaintRect):
Source/WebKit/chromium:
* src/WebFrameImpl.cpp:
(WebKit::ChromePrintContext::computePageRects):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101705 => 101706)
--- trunk/Source/WebCore/ChangeLog 2011-12-01 22:12:16 UTC (rev 101705)
+++ trunk/Source/WebCore/ChangeLog 2011-12-01 22:16:10 UTC (rev 101706)
@@ -1,3 +1,13 @@
+2011-12-01 Kelly Norton <[email protected]>
+
+ More void functions eager to return values in RenderObject & WebFrameImpl
+ https://bugs.webkit.org/show_bug.cgi?id=73571
+
+ Reviewed by Adam Barth.
+
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::computeAbsoluteRepaintRect):
+
2011-12-01 Sheriff Bot <[email protected]>
Unreviewed, rolling out r101691.
Modified: trunk/Source/WebCore/rendering/RenderObject.h (101705 => 101706)
--- trunk/Source/WebCore/rendering/RenderObject.h 2011-12-01 22:12:16 UTC (rev 101705)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2011-12-01 22:16:10 UTC (rev 101706)
@@ -711,7 +711,7 @@
// that rect in view coordinates.
void computeAbsoluteRepaintRect(LayoutRect& r, bool fixed = false) const
{
- return computeRectForRepaint(0, r, fixed);
+ computeRectForRepaint(0, r, fixed);
}
// Given a rect in the object's coordinate space, compute a rect suitable for repainting
// that rect in the coordinate space of repaintContainer.
Modified: trunk/Source/WebKit/chromium/ChangeLog (101705 => 101706)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-01 22:12:16 UTC (rev 101705)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-01 22:16:10 UTC (rev 101706)
@@ -1,3 +1,13 @@
+2011-12-01 Kelly Norton <[email protected]>
+
+ More void functions eager to return values in RenderObject & WebFrameImpl
+ https://bugs.webkit.org/show_bug.cgi?id=73571
+
+ Reviewed by Adam Barth.
+
+ * src/WebFrameImpl.cpp:
+ (WebKit::ChromePrintContext::computePageRects):
+
2011-12-01 Daniel Sievers <[email protected]>
[Chromium] Early returns in calculateDrawTransformsAndVisibilityInternal() are not respected by parent.
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (101705 => 101706)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2011-12-01 22:12:16 UTC (rev 101705)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2011-12-01 22:16:10 UTC (rev 101706)
@@ -415,7 +415,7 @@
virtual void computePageRects(const FloatRect& printRect, float headerHeight, float footerHeight, float userScaleFactor, float& outPageHeight)
{
- return PrintContext::computePageRects(printRect, headerHeight, footerHeight, userScaleFactor, outPageHeight);
+ PrintContext::computePageRects(printRect, headerHeight, footerHeight, userScaleFactor, outPageHeight);
}
virtual int pageCount() const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
