Title: [237301] trunk/Tools
Revision
237301
Author
[email protected]
Date
2018-10-19 14:17:19 -0700 (Fri, 19 Oct 2018)

Log Message

ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
https://bugs.webkit.org/show_bug.cgi?id=186946
<rdar://problem/41724248>

Reviewed by Antoine Quint.

If the incoming test has different enableWebAnimationsCSSIntegration options,
then we need to create a new WebView.

* DumpRenderTree/TestOptions.cpp:
(TestOptions::webViewIsCompatibleWithOptions const):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (237300 => 237301)


--- trunk/Tools/ChangeLog	2018-10-19 21:12:24 UTC (rev 237300)
+++ trunk/Tools/ChangeLog	2018-10-19 21:17:19 UTC (rev 237301)
@@ -1,3 +1,17 @@
+2018-10-19  Dean Jackson  <[email protected]>
+
+        ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
+        https://bugs.webkit.org/show_bug.cgi?id=186946
+        <rdar://problem/41724248>
+
+        Reviewed by Antoine Quint.
+
+        If the incoming test has different enableWebAnimationsCSSIntegration options,
+        then we need to create a new WebView.
+
+        * DumpRenderTree/TestOptions.cpp:
+        (TestOptions::webViewIsCompatibleWithOptions const):
+
 2018-10-19  Charlie Turner  <[email protected]>
 
         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context

Modified: trunk/Tools/DumpRenderTree/TestOptions.cpp (237300 => 237301)


--- trunk/Tools/DumpRenderTree/TestOptions.cpp	2018-10-19 21:12:24 UTC (rev 237300)
+++ trunk/Tools/DumpRenderTree/TestOptions.cpp	2018-10-19 21:17:19 UTC (rev 237301)
@@ -116,5 +116,6 @@
 bool TestOptions::webViewIsCompatibleWithOptions(const TestOptions& other) const
 {
     return other.layerBackedWebView == layerBackedWebView
-        && other.jscOptions == jscOptions;
+        && other.jscOptions == jscOptions
+        && other.enableWebAnimationsCSSIntegration == enableWebAnimationsCSSIntegration;
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to