Diff
Modified: trunk/Tools/ChangeLog (237309 => 237310)
--- trunk/Tools/ChangeLog 2018-10-20 02:57:41 UTC (rev 237309)
+++ trunk/Tools/ChangeLog 2018-10-20 07:00:09 UTC (rev 237310)
@@ -1,3 +1,17 @@
+2018-10-19 Dan Bernstein <[email protected]>
+
+ [macOS] MiniBrowser has an unused injected bundle
+ https://bugs.webkit.org/show_bug.cgi?id=190770
+
+ Reviewed by Tim Horton.
+
+ * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
+ * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
+ the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
+ * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
+ * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
+ * MiniBrowser/mac/Bundle: Removed.
+
2018-10-19 Wenson Hsieh <[email protected]>
[iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
Deleted: trunk/Tools/MiniBrowser/Configurations/MiniBrowserBundle.xcconfig (237309 => 237310)
--- trunk/Tools/MiniBrowser/Configurations/MiniBrowserBundle.xcconfig 2018-10-20 02:57:41 UTC (rev 237309)
+++ trunk/Tools/MiniBrowser/Configurations/MiniBrowserBundle.xcconfig 2018-10-20 07:00:09 UTC (rev 237310)
@@ -1,30 +0,0 @@
-// Copyright (C) 2013 Apple Inc. All rights reserved.
-//
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions
-// are met:
-// 1. Redistributions of source code must retain the above copyright
-// notice, this list of conditions and the following disclaimer.
-// 2. Redistributions in binary form must reproduce the above copyright
-// notice, this list of conditions and the following disclaimer in the
-// documentation and/or other materials provided with the distribution.
-//
-// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
-// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-// PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
-// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
-// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-PRODUCT_NAME = MiniBrowser
-PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier)
-WRAPPER_EXTENSION = wkbundle
-GCC_PREFIX_HEADER = mac/Bundle/MiniBrowserBundle_Prefix.pch
-INFOPLIST_FILE = mac/Bundle/Info.plist
-EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *
-OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Cocoa
Modified: trunk/Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj (237309 => 237310)
--- trunk/Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj 2018-10-20 02:57:41 UTC (rev 237309)
+++ trunk/Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj 2018-10-20 07:00:09 UTC (rev 237310)
@@ -9,8 +9,6 @@
/* Begin PBXBuildFile section */
0FE643A1161FA8940059E3FF /* BrowserWindowController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0FE643A0161FA8940059E3FF /* BrowserWindowController.m */; };
0FE643A4161FAC660059E3FF /* WK1BrowserWindowController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0FE643A3161FAC660059E3FF /* WK1BrowserWindowController.m */; };
- 1AFFEF8818611C3D00DA465E /* MiniBrowserWebProcessPlugIn.m in Sources */ = {isa = PBXBuildFile; fileRef = 1AFFEF8618611C3D00DA465E /* MiniBrowserWebProcessPlugIn.m */; };
- 1AFFEF8B18611D8A00DA465E /* MiniBrowser.wkbundle in Copy Bundle */ = {isa = PBXBuildFile; fileRef = 1AFFEF751860EE6700DA465E /* MiniBrowser.wkbundle */; };
256AC3DA0F4B6AC300CF3369 /* AppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 256AC3D90F4B6AC300CF3369 /* AppDelegate.m */; };
2DC37343198B62D300EC33E9 /* SettingsController.m in Sources */ = {isa = PBXBuildFile; fileRef = 2DC37342198B62D300EC33E9 /* SettingsController.m */; };
51E244FA11EFCE07008228D1 /* MBToolbarItem.m in Sources */ = {isa = PBXBuildFile; fileRef = 51E244F911EFCE07008228D1 /* MBToolbarItem.m */; };
@@ -22,43 +20,13 @@
BC72B89611E57E0F001EB4EA /* BrowserWindow.xib in Resources */ = {isa = PBXBuildFile; fileRef = BC3294A2116A9852008635D0 /* BrowserWindow.xib */; };
/* End PBXBuildFile section */
-/* Begin PBXContainerItemProxy section */
- 1AFFEF8918611D0500DA465E /* PBXContainerItemProxy */ = {
- isa = PBXContainerItemProxy;
- containerPortal = 29B97313FDCFA39411CA2CEA /* Project object */;
- proxyType = 1;
- remoteGlobalIDString = 1AFFEF741860EE6700DA465E;
- remoteInfo = MiniBrowserBundle;
- };
-/* End PBXContainerItemProxy section */
-
-/* Begin PBXCopyFilesBuildPhase section */
- BCBD38CF11B08C0100E01E54 /* Copy Bundle */ = {
- isa = PBXCopyFilesBuildPhase;
- buildActionMask = 2147483647;
- dstPath = Contents;
- dstSubfolderSpec = 1;
- files = (
- 1AFFEF8B18611D8A00DA465E /* MiniBrowser.wkbundle in Copy Bundle */,
- );
- name = "Copy Bundle";
- runOnlyForDeploymentPostprocessing = 0;
- };
-/* End PBXCopyFilesBuildPhase section */
-
/* Begin PBXFileReference section */
0FE6439F161FA8940059E3FF /* BrowserWindowController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = BrowserWindowController.h; path = mac/BrowserWindowController.h; sourceTree = "<group>"; };
0FE643A0161FA8940059E3FF /* BrowserWindowController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = BrowserWindowController.m; path = mac/BrowserWindowController.m; sourceTree = "<group>"; };
0FE643A2161FAC660059E3FF /* WK1BrowserWindowController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = WK1BrowserWindowController.h; path = mac/WK1BrowserWindowController.h; sourceTree = "<group>"; };
0FE643A3161FAC660059E3FF /* WK1BrowserWindowController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = WK1BrowserWindowController.m; path = mac/WK1BrowserWindowController.m; sourceTree = "<group>"; };
- 1AFFEF751860EE6700DA465E /* MiniBrowser.wkbundle */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = MiniBrowser.wkbundle; sourceTree = BUILT_PRODUCTS_DIR; };
1AFFEF761860EE6800DA465E /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = System/Library/Frameworks/Cocoa.framework; sourceTree = SDKROOT; };
1AFFEF781860EE6800DA465E /* CoreData.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreData.framework; path = System/Library/Frameworks/CoreData.framework; sourceTree = SDKROOT; };
- 1AFFEF831860EEFB00DA465E /* MiniBrowserBundle.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = MiniBrowserBundle.xcconfig; sourceTree = "<group>"; };
- 1AFFEF841860EF2200DA465E /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
- 1AFFEF851860EF2200DA465E /* MiniBrowserBundle_Prefix.pch */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MiniBrowserBundle_Prefix.pch; sourceTree = "<group>"; };
- 1AFFEF8618611C3D00DA465E /* MiniBrowserWebProcessPlugIn.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = MiniBrowserWebProcessPlugIn.m; sourceTree = SOURCE_ROOT; };
- 1AFFEF8718611C3D00DA465E /* MiniBrowserWebProcessPlugIn.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MiniBrowserWebProcessPlugIn.h; sourceTree = SOURCE_ROOT; };
1DDD58150DA1D0A300B32029 /* MainMenu.xib */ = {isa = PBXFileReference; lastKnownFileType = file.xib; name = MainMenu.xib; path = mac/MainMenu.xib; sourceTree = "<group>"; };
256AC3D80F4B6AC300CF3369 /* AppDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AppDelegate.h; path = mac/AppDelegate.h; sourceTree = "<group>"; };
256AC3D90F4B6AC300CF3369 /* AppDelegate.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = AppDelegate.m; path = mac/AppDelegate.m; sourceTree = "<group>"; };
@@ -86,13 +54,6 @@
/* End PBXFileReference section */
/* Begin PBXFrameworksBuildPhase section */
- 1AFFEF721860EE6700DA465E /* Frameworks */ = {
- isa = PBXFrameworksBuildPhase;
- buildActionMask = 2147483647;
- files = (
- );
- runOnlyForDeploymentPostprocessing = 0;
- };
8D11072E0486CEB800E47090 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
@@ -142,23 +103,10 @@
isa = PBXGroup;
children = (
8D1107320486CEB800E47090 /* MiniBrowser.app */,
- 1AFFEF751860EE6700DA465E /* MiniBrowser.wkbundle */,
);
name = Products;
sourceTree = "<group>";
};
- 1AFFEF791860EE6800DA465E /* Bundle */ = {
- isa = PBXGroup;
- children = (
- 1AFFEF841860EF2200DA465E /* Info.plist */,
- 1AFFEF851860EF2200DA465E /* MiniBrowserBundle_Prefix.pch */,
- 1AFFEF8718611C3D00DA465E /* MiniBrowserWebProcessPlugIn.h */,
- 1AFFEF8618611C3D00DA465E /* MiniBrowserWebProcessPlugIn.m */,
- );
- name = Bundle;
- path = mac/Bundle;
- sourceTree = "<group>";
- };
29B97314FDCFA39411CA2CEA /* MiniBrowser */ = {
isa = PBXGroup;
children = (
@@ -166,7 +114,6 @@
080E96DDFE201D6D7F000001 /* MiniBrowser */,
29B97317FDCFA39411CA2CEA /* Resources */,
BCA8CBDA11E5787800812FB7 /* Configurations */,
- 1AFFEF791860EE6800DA465E /* Bundle */,
29B97323FDCFA39411CA2CEA /* Frameworks */,
19C28FACFE9D520D11CA2CBB /* Products */,
);
@@ -198,7 +145,6 @@
BCA8CBDD11E578A000812FB7 /* Base.xcconfig */,
BCA8CBDE11E578A000812FB7 /* DebugRelease.xcconfig */,
BCA8CBDF11E578A000812FB7 /* MiniBrowser.xcconfig */,
- 1AFFEF831860EEFB00DA465E /* MiniBrowserBundle.xcconfig */,
);
path = Configurations;
sourceTree = "<group>";
@@ -206,29 +152,11 @@
/* End PBXGroup section */
/* Begin PBXNativeTarget section */
- 1AFFEF741860EE6700DA465E /* MiniBrowserBundle */ = {
- isa = PBXNativeTarget;
- buildConfigurationList = 1AFFEF821860EE6800DA465E /* Build configuration list for PBXNativeTarget "MiniBrowserBundle" */;
- buildPhases = (
- 1AFFEF711860EE6700DA465E /* Sources */,
- 1AFFEF721860EE6700DA465E /* Frameworks */,
- 1AFFEF731860EE6700DA465E /* Resources */,
- );
- buildRules = (
- );
- dependencies = (
- );
- name = MiniBrowserBundle;
- productName = Bundle;
- productReference = 1AFFEF751860EE6700DA465E /* MiniBrowser.wkbundle */;
- productType = "com.apple.product-type.bundle";
- };
8D1107260486CEB800E47090 /* MiniBrowser */ = {
isa = PBXNativeTarget;
buildConfigurationList = C01FCF4A08A954540054247B /* Build configuration list for PBXNativeTarget "MiniBrowser" */;
buildPhases = (
8D1107290486CEB800E47090 /* Resources */,
- BCBD38CF11B08C0100E01E54 /* Copy Bundle */,
8D11072C0486CEB800E47090 /* Sources */,
8D11072E0486CEB800E47090 /* Frameworks */,
);
@@ -235,7 +163,6 @@
buildRules = (
);
dependencies = (
- 1AFFEF8A18611D0500DA465E /* PBXTargetDependency */,
);
name = MiniBrowser;
productInstallPath = "$(HOME)/Applications";
@@ -277,19 +204,11 @@
projectRoot = "";
targets = (
8D1107260486CEB800E47090 /* MiniBrowser */,
- 1AFFEF741860EE6700DA465E /* MiniBrowserBundle */,
);
};
/* End PBXProject section */
/* Begin PBXResourcesBuildPhase section */
- 1AFFEF731860EE6700DA465E /* Resources */ = {
- isa = PBXResourcesBuildPhase;
- buildActionMask = 2147483647;
- files = (
- );
- runOnlyForDeploymentPostprocessing = 0;
- };
8D1107290486CEB800E47090 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
@@ -303,14 +222,6 @@
/* End PBXResourcesBuildPhase section */
/* Begin PBXSourcesBuildPhase section */
- 1AFFEF711860EE6700DA465E /* Sources */ = {
- isa = PBXSourcesBuildPhase;
- buildActionMask = 2147483647;
- files = (
- 1AFFEF8818611C3D00DA465E /* MiniBrowserWebProcessPlugIn.m in Sources */,
- );
- runOnlyForDeploymentPostprocessing = 0;
- };
8D11072C0486CEB800E47090 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
@@ -328,29 +239,7 @@
};
/* End PBXSourcesBuildPhase section */
-/* Begin PBXTargetDependency section */
- 1AFFEF8A18611D0500DA465E /* PBXTargetDependency */ = {
- isa = PBXTargetDependency;
- target = 1AFFEF741860EE6700DA465E /* MiniBrowserBundle */;
- targetProxy = 1AFFEF8918611D0500DA465E /* PBXContainerItemProxy */;
- };
-/* End PBXTargetDependency section */
-
/* Begin XCBuildConfiguration section */
- 1AFFEF801860EE6800DA465E /* Debug */ = {
- isa = XCBuildConfiguration;
- baseConfigurationReference = 1AFFEF831860EEFB00DA465E /* MiniBrowserBundle.xcconfig */;
- buildSettings = {
- };
- name = Debug;
- };
- 1AFFEF811860EE6800DA465E /* Release */ = {
- isa = XCBuildConfiguration;
- baseConfigurationReference = 1AFFEF831860EEFB00DA465E /* MiniBrowserBundle.xcconfig */;
- buildSettings = {
- };
- name = Release;
- };
C01FCF4B08A954540054247B /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = BCA8CBDF11E578A000812FB7 /* MiniBrowser.xcconfig */;
@@ -383,15 +272,6 @@
/* End XCBuildConfiguration section */
/* Begin XCConfigurationList section */
- 1AFFEF821860EE6800DA465E /* Build configuration list for PBXNativeTarget "MiniBrowserBundle" */ = {
- isa = XCConfigurationList;
- buildConfigurations = (
- 1AFFEF801860EE6800DA465E /* Debug */,
- 1AFFEF811860EE6800DA465E /* Release */,
- );
- defaultConfigurationIsVisible = 0;
- defaultConfigurationName = Release;
- };
C01FCF4A08A954540054247B /* Build configuration list for PBXNativeTarget "MiniBrowser" */ = {
isa = XCConfigurationList;
buildConfigurations = (
Deleted: trunk/Tools/MiniBrowser/MiniBrowserWebProcessPlugIn.h (237309 => 237310)
--- trunk/Tools/MiniBrowser/MiniBrowserWebProcessPlugIn.h 2018-10-20 02:57:41 UTC (rev 237309)
+++ trunk/Tools/MiniBrowser/MiniBrowserWebProcessPlugIn.h 2018-10-20 07:00:09 UTC (rev 237310)
@@ -1,34 +0,0 @@
-/*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#import <WebKit/WKWebProcessPlugIn.h>
-
-#if WK_API_ENABLED
-
-@interface MiniBrowserWebProcessPlugIn : NSObject <WKWebProcessPlugIn>
-
-@end
-
-#endif // WK_API_ENABLED
Deleted: trunk/Tools/MiniBrowser/MiniBrowserWebProcessPlugIn.m (237309 => 237310)
--- trunk/Tools/MiniBrowser/MiniBrowserWebProcessPlugIn.m 2018-10-20 02:57:41 UTC (rev 237309)
+++ trunk/Tools/MiniBrowser/MiniBrowserWebProcessPlugIn.m 2018-10-20 07:00:09 UTC (rev 237310)
@@ -1,38 +0,0 @@
-/*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#import "MiniBrowserWebProcessPlugIn.h"
-
-#if WK_API_ENABLED
-
-@implementation MiniBrowserWebProcessPlugIn
-
-- (void)webProcessPlugIn:(WKWebProcessPlugInController *)plugInController initializeWithObject:(id)initializationObject
-{
-}
-
-@end
-
-#endif // WK_API_ENABLED
