Title: [101716] trunk/Source/WebCore
- Revision
- 101716
- Author
- [email protected]
- Date
- 2011-12-01 15:06:57 -0800 (Thu, 01 Dec 2011)
Log Message
V8 bindings cleanup: V8WindowErrorHandler shouldn't be directly invoking script
https://bugs.webkit.org/show_bug.cgi?id=73576
Patch by Rafael Weinstein <[email protected]> on 2011-12-01
Reviewed by Adam Barth.
No tests needed. This patch is just bindings hygiene.
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101715 => 101716)
--- trunk/Source/WebCore/ChangeLog 2011-12-01 23:00:22 UTC (rev 101715)
+++ trunk/Source/WebCore/ChangeLog 2011-12-01 23:06:57 UTC (rev 101716)
@@ -1,3 +1,15 @@
+2011-12-01 Rafael Weinstein <[email protected]>
+
+ V8 bindings cleanup: V8WindowErrorHandler shouldn't be directly invoking script
+ https://bugs.webkit.org/show_bug.cgi?id=73576
+
+ Reviewed by Adam Barth.
+
+ No tests needed. This patch is just bindings hygiene.
+
+ * bindings/v8/V8WindowErrorHandler.cpp:
+ (WebCore::V8WindowErrorHandler::callListenerFunction):
+
2011-12-01 Benjamin Poulain <[email protected]>
URLs are encoded in UTF-8, then decoded as if they are Latin1
Modified: trunk/Source/WebCore/bindings/v8/V8WindowErrorHandler.cpp (101715 => 101716)
--- trunk/Source/WebCore/bindings/v8/V8WindowErrorHandler.cpp 2011-12-01 23:00:22 UTC (rev 101715)
+++ trunk/Source/WebCore/bindings/v8/V8WindowErrorHandler.cpp 2011-12-01 23:06:57 UTC (rev 101716)
@@ -35,6 +35,7 @@
#include "EventNames.h"
#include "ErrorEvent.h"
#include "V8Binding.h"
+#include "V8Proxy.h"
namespace WebCore {
@@ -57,7 +58,7 @@
v8::Handle<v8::Value> parameters[3] = { v8String(errorEvent->message()), v8String(errorEvent->filename()), v8::Integer::New(errorEvent->lineno()) };
v8::TryCatch tryCatch;
tryCatch.SetVerbose(true);
- returnValue = callFunction->Call(thisValue, 3, parameters);
+ returnValue = V8Proxy::instrumentedCallFunction(0 /* page */, callFunction, thisValue, 3, parameters);
}
return returnValue;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
