Title: [237327] trunk/Source/WebInspectorUI
- Revision
- 237327
- Author
- [email protected]
- Date
- 2018-10-22 12:24:04 -0700 (Mon, 22 Oct 2018)
Log Message
Web Inspector: Open Quickly dialog doesn't show named scripts that appear in the debugger sidebar
https://bugs.webkit.org/show_bug.cgi?id=190649
Patch by Joseph Pecoraro <[email protected]> on 2018-10-22
Reviewed by Devin Rousso.
* UserInterface/Views/OpenResourceDialog.js:
(WI.OpenResourceDialog.prototype.didPresentDialog):
(WI.OpenResourceDialog.prototype._addResourcesForTarget):
(WI.OpenResourceDialog.prototype._addScriptsForTarget):
Include non-resource named scripts from the main target in
the open quickly dialog.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (237326 => 237327)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-22 19:07:37 UTC (rev 237326)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-22 19:24:04 UTC (rev 237327)
@@ -1,3 +1,17 @@
+2018-10-22 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Open Quickly dialog doesn't show named scripts that appear in the debugger sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=190649
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/OpenResourceDialog.js:
+ (WI.OpenResourceDialog.prototype.didPresentDialog):
+ (WI.OpenResourceDialog.prototype._addResourcesForTarget):
+ (WI.OpenResourceDialog.prototype._addScriptsForTarget):
+ Include non-resource named scripts from the main target in
+ the open quickly dialog.
+
2018-10-19 Joseph Pecoraro <[email protected]>
Web Inspector: Remove unused member variable of DebuggerSidebarPanel
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js (237326 => 237327)
--- trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js 2018-10-22 19:07:37 UTC (rev 237326)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js 2018-10-22 19:24:04 UTC (rev 237327)
@@ -147,6 +147,8 @@
if (WI.networkManager.mainFrame)
this._addResourcesForFrame(WI.networkManager.mainFrame);
+ this._addScriptsForTarget(WI.mainTarget);
+
for (let target of WI.targets) {
if (target !== WI.mainTarget)
this._addResourcesForTarget(target);
@@ -312,12 +314,21 @@
for (let resource of target.resourceCollection)
this._addResource(resource, suppressFilterUpdate);
+ this._addScriptsForTarget(target);
+ }
+
+ _addScriptsForTarget(target)
+ {
+ const suppressFilterUpdate = true;
+
let targetData = WI.debuggerManager.dataForTarget(target);
for (let script of targetData.scripts) {
if (script.resource)
continue;
- if (isWebKitInternalScript(script.sourceURL) || isWebInspectorConsoleEvaluationScript(script.sourceURL))
+ if (script.dynamicallyAddedScriptElement)
continue;
+ if (!script.sourceURL || isWebKitInternalScript(script.sourceURL) || isWebInspectorConsoleEvaluationScript(script.sourceURL))
+ continue;
this._addResource(script, suppressFilterUpdate);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
