Title: [237330] trunk/Source/WebKitLegacy
- Revision
- 237330
- Author
- [email protected]
- Date
- 2018-10-22 14:05:20 -0700 (Mon, 22 Oct 2018)
Log Message
Regression (r232410): StorageTracker.db file gets unlinked while in use
https://bugs.webkit.org/show_bug.cgi?id=190795
Reviewed by Chris Dumez.
WK2 stopped using StorageTracker.db file in r232410 and would delete
the file for safety.
It turned out WK1 could use the same file path, so WK2 may delete the
file while WK1 is using it.
* Storage/StorageTracker.cpp:
(WebKit::StorageTracker::trackerDatabasePath):
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/ChangeLog (237329 => 237330)
--- trunk/Source/WebKitLegacy/ChangeLog 2018-10-22 21:05:02 UTC (rev 237329)
+++ trunk/Source/WebKitLegacy/ChangeLog 2018-10-22 21:05:20 UTC (rev 237330)
@@ -1,3 +1,18 @@
+2018-10-22 Sihui Liu <[email protected]>
+
+ Regression (r232410): StorageTracker.db file gets unlinked while in use
+ https://bugs.webkit.org/show_bug.cgi?id=190795
+
+ Reviewed by Chris Dumez.
+
+ WK2 stopped using StorageTracker.db file in r232410 and would delete
+ the file for safety.
+ It turned out WK1 could use the same file path, so WK2 may delete the
+ file while WK1 is using it.
+
+ * Storage/StorageTracker.cpp:
+ (WebKit::StorageTracker::trackerDatabasePath):
+
2018-10-18 Alexey Proskuryakov <[email protected]>
Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKitLegacy/Storage/StorageTracker.cpp (237329 => 237330)
--- trunk/Source/WebKitLegacy/Storage/StorageTracker.cpp 2018-10-22 21:05:02 UTC (rev 237329)
+++ trunk/Source/WebKitLegacy/Storage/StorageTracker.cpp 2018-10-22 21:05:20 UTC (rev 237330)
@@ -104,7 +104,7 @@
String StorageTracker::trackerDatabasePath()
{
ASSERT(!m_databaseMutex.tryLock());
- return FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "StorageTracker.db");
+ return FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "LegacyStorageTracker.db");
}
static bool ensureDatabaseFileExists(const String& fileName, bool createIfDoesNotExist)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
