Title: [101718] trunk
- Revision
- 101718
- Author
- [email protected]
- Date
- 2011-12-01 15:17:49 -0800 (Thu, 01 Dec 2011)
Log Message
[FileSystem API] DirectoryEntry.removeRecursively successCallback is required
https://bugs.webkit.org/show_bug.cgi?id=69644
Patch by Mark Pilgrim <[email protected]> on 2011-12-01
Reviewed by Adam Barth.
Source/WebCore:
* fileapi/DirectoryEntry.idl: remove [Optional] flag from successCallback
LayoutTests:
* fast/filesystem/not-enough-arguments-expected.txt: add removeRecursively test result
* fast/filesystem/not-enough-arguments.html: add removeRecursively test
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (101717 => 101718)
--- trunk/LayoutTests/ChangeLog 2011-12-01 23:14:42 UTC (rev 101717)
+++ trunk/LayoutTests/ChangeLog 2011-12-01 23:17:49 UTC (rev 101718)
@@ -1,5 +1,15 @@
2011-12-01 Mark Pilgrim <[email protected]>
+ [FileSystem API] DirectoryEntry.removeRecursively successCallback is required
+ https://bugs.webkit.org/show_bug.cgi?id=69644
+
+ Reviewed by Adam Barth.
+
+ * fast/filesystem/not-enough-arguments-expected.txt: add removeRecursively test result
+ * fast/filesystem/not-enough-arguments.html: add removeRecursively test
+
+2011-12-01 Mark Pilgrim <[email protected]>
+
[FileSystem API] DirectoryEntry.getDirectory path argument is required
https://bugs.webkit.org/show_bug.cgi?id=69643
Modified: trunk/LayoutTests/fast/filesystem/not-enough-arguments-expected.txt (101717 => 101718)
--- trunk/LayoutTests/fast/filesystem/not-enough-arguments-expected.txt 2011-12-01 23:14:42 UTC (rev 101717)
+++ trunk/LayoutTests/fast/filesystem/not-enough-arguments-expected.txt 2011-12-01 23:17:49 UTC (rev 101718)
@@ -4,6 +4,7 @@
Successfully obtained Persistent FileSystem:file__0:Temporary
+PASS fileSystem.root.removeRecursively() threw exception TypeError: Not enough arguments.
PASS fileSystem.root.moveTo() threw exception TypeError: Not enough arguments.
PASS fileSystem.root.copyTo() threw exception TypeError: Not enough arguments.
PASS reader.readEntries() threw exception TypeError: Not enough arguments.
Modified: trunk/LayoutTests/fast/filesystem/not-enough-arguments.html (101717 => 101718)
--- trunk/LayoutTests/fast/filesystem/not-enough-arguments.html 2011-12-01 23:14:42 UTC (rev 101717)
+++ trunk/LayoutTests/fast/filesystem/not-enough-arguments.html 2011-12-01 23:17:49 UTC (rev 101718)
@@ -18,6 +18,7 @@
fileSystem = fs;
debug("Successfully obtained Persistent FileSystem:" + fileSystem.name);
+ shouldThrow("fileSystem.root.removeRecursively()");
shouldThrow("fileSystem.root.moveTo()");
shouldThrow("fileSystem.root.copyTo()");
reader = fileSystem.root.createReader();
Modified: trunk/Source/WebCore/ChangeLog (101717 => 101718)
--- trunk/Source/WebCore/ChangeLog 2011-12-01 23:14:42 UTC (rev 101717)
+++ trunk/Source/WebCore/ChangeLog 2011-12-01 23:17:49 UTC (rev 101718)
@@ -1,5 +1,14 @@
2011-12-01 Mark Pilgrim <[email protected]>
+ [FileSystem API] DirectoryEntry.removeRecursively successCallback is required
+ https://bugs.webkit.org/show_bug.cgi?id=69644
+
+ Reviewed by Adam Barth.
+
+ * fileapi/DirectoryEntry.idl: remove [Optional] flag from successCallback
+
+2011-12-01 Mark Pilgrim <[email protected]>
+
[FileSystem API] DirectoryEntry.getDirectory path argument is required
https://bugs.webkit.org/show_bug.cgi?id=69643
Modified: trunk/Source/WebCore/fileapi/DirectoryEntry.idl (101717 => 101718)
--- trunk/Source/WebCore/fileapi/DirectoryEntry.idl 2011-12-01 23:14:42 UTC (rev 101717)
+++ trunk/Source/WebCore/fileapi/DirectoryEntry.idl 2011-12-01 23:17:49 UTC (rev 101718)
@@ -38,6 +38,6 @@
DirectoryReader createReader();
[Custom] void getFile(in [ConvertUndefinedOrNullToNullString] DOMString path, in [Optional] WebKitFlags flags, in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
[Custom] void getDirectory(in [ConvertUndefinedOrNullToNullString] DOMString path, in [Optional] WebKitFlags flags, in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
- void removeRecursively(in [Optional, Callback] VoidCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
+ void removeRecursively(in [Callback] VoidCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
};
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
