Title: [237346] trunk/Tools
- Revision
- 237346
- Author
- [email protected]
- Date
- 2018-10-22 18:52:04 -0700 (Mon, 22 Oct 2018)
Log Message
REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
https://bugs.webkit.org/show_bug.cgi?id=190801
<rdar://problem/43674361>
* TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
(TEST):
Use a parented WKWebView for this test, otherwise none of the assertions
about gesture recognizers work anymore.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (237345 => 237346)
--- trunk/Tools/ChangeLog 2018-10-23 00:52:37 UTC (rev 237345)
+++ trunk/Tools/ChangeLog 2018-10-23 01:52:04 UTC (rev 237346)
@@ -1,3 +1,14 @@
+2018-10-22 Tim Horton <[email protected]>
+
+ REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
+ https://bugs.webkit.org/show_bug.cgi?id=190801
+ <rdar://problem/43674361>
+
+ * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
+ (TEST):
+ Use a parented WKWebView for this test, otherwise none of the assertions
+ about gesture recognizers work anymore.
+
2018-10-22 Ryan Haddad <[email protected]>
REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm (237345 => 237346)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm 2018-10-23 00:52:37 UTC (rev 237345)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm 2018-10-23 01:52:04 UTC (rev 237346)
@@ -28,6 +28,7 @@
#import "PlatformUtilities.h"
#import "Test.h"
#import "TestNavigationDelegate.h"
+#import "TestWKWebView.h"
#import <WebKit/WKWebViewConfigurationPrivate.h>
#import <WebKit/WKWebViewPrivate.h>
#import <wtf/RetainPtr.h>
@@ -60,7 +61,7 @@
{
RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
- RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]);
+ RetainPtr<WKWebView> webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]);
[webView loadHTMLString:@"test" baseURL:nil];
[webView _test_waitForDidFinishNavigation];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
