Title: [237349] trunk/Source/WebInspectorUI
- Revision
- 237349
- Author
- [email protected]
- Date
- 2018-10-23 02:52:54 -0700 (Tue, 23 Oct 2018)
Log Message
Uncaught Exception: TypeError: null is not an object (evaluating 'mouseBlock.addEventListener')
https://bugs.webkit.org/show_bug.cgi?id=190766
Reviewed by Brian Burg.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
When creating the `mouseBlock`, if the `startTimestamp` and `endTimestamp` are equal, we
don't create an element. If this is true for the total range of the `WI.Resouce` (meaning
its `startTime` and `responseEnd`), don't even try to create blocks.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (237348 => 237349)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-23 09:50:14 UTC (rev 237348)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-23 09:52:54 UTC (rev 237349)
@@ -1,5 +1,18 @@
2018-10-23 Devin Rousso <[email protected]>
+ Uncaught Exception: TypeError: null is not an object (evaluating 'mouseBlock.addEventListener')
+ https://bugs.webkit.org/show_bug.cgi?id=190766
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView.prototype._populateWaterfallGraph):
+ When creating the `mouseBlock`, if the `startTimestamp` and `endTimestamp` are equal, we
+ don't create an element. If this is true for the total range of the `WI.Resouce` (meaning
+ its `startTime` and `responseEnd`), don't even try to create blocks.
+
+2018-10-23 Devin Rousso <[email protected]>
+
Web Inspector: "Queued NaNms" in Network tab
https://bugs.webkit.org/show_bug.cgi?id=190767
<rdar://problem/45420859>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (237348 => 237349)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2018-10-23 09:50:14 UTC (rev 237348)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2018-10-23 09:52:54 UTC (rev 237349)
@@ -728,7 +728,7 @@
}
let {startTime, redirectStart, redirectEnd, fetchStart, domainLookupStart, domainLookupEnd, connectStart, connectEnd, secureConnectionStart, requestStart, responseStart, responseEnd} = resource.timingData;
- if (isNaN(startTime) || isNaN(responseEnd)) {
+ if (isNaN(startTime) || isNaN(responseEnd) || startTime >= responseEnd) {
cell.textContent = zeroWidthSpace;
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
