Title: [237388] branches/safari-606-branch/Source/WebCore
Revision
237388
Author
[email protected]
Date
2018-10-24 09:56:08 -0700 (Wed, 24 Oct 2018)

Log Message

Cherry-pick r236747. rdar://problem/45491954

    Add release assertion to ensure m_owningPointerForClose is null in UniqueIDBDatabase::invokeOperationAndTransactionTimer()
    https://bugs.webkit.org/show_bug.cgi?id=190178

    Reviewed by Chris Dumez.

    This would help debug rdar://problem/44902833.

    * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
    (WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-606-branch/Source/WebCore/ChangeLog (237387 => 237388)


--- branches/safari-606-branch/Source/WebCore/ChangeLog	2018-10-24 16:56:04 UTC (rev 237387)
+++ branches/safari-606-branch/Source/WebCore/ChangeLog	2018-10-24 16:56:08 UTC (rev 237388)
@@ -1,5 +1,34 @@
 2018-10-24  Kocsen Chung  <[email protected]>
 
+        Cherry-pick r236747. rdar://problem/45491954
+
+    Add release assertion to ensure m_owningPointerForClose is null in UniqueIDBDatabase::invokeOperationAndTransactionTimer()
+    https://bugs.webkit.org/show_bug.cgi?id=190178
+    
+    Reviewed by Chris Dumez.
+    
+    This would help debug rdar://problem/44902833.
+    
+    * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+    (WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-10-02  Sihui Liu  <[email protected]>
+
+            Add release assertion to ensure m_owningPointerForClose is null in UniqueIDBDatabase::invokeOperationAndTransactionTimer()
+            https://bugs.webkit.org/show_bug.cgi?id=190178
+
+            Reviewed by Chris Dumez.
+
+            This would help debug rdar://problem/44902833.
+
+            * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+            (WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer):
+
+2018-10-24  Kocsen Chung  <[email protected]>
+
         Cherry-pick r234791. rdar://problem/45491958
 
     CrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient(WebCore::IDBServer::UniqueIDBDatabaseConnection&)

Modified: branches/safari-606-branch/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (237387 => 237388)


--- branches/safari-606-branch/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2018-10-24 16:56:04 UTC (rev 237387)
+++ branches/safari-606-branch/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2018-10-24 16:56:08 UTC (rev 237388)
@@ -1533,8 +1533,8 @@
 void UniqueIDBDatabase::invokeOperationAndTransactionTimer()
 {
     LOG(IndexedDB, "UniqueIDBDatabase::invokeOperationAndTransactionTimer()");
-    ASSERT(!m_hardClosedForUserDelete);
-    ASSERT(!m_owningPointerForClose);
+    RELEASE_ASSERT(!m_hardClosedForUserDelete);
+    RELEASE_ASSERT(!m_owningPointerForClose);
 
     if (!m_operationAndTransactionTimer.isActive())
         m_operationAndTransactionTimer.startOneShot(0_s);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to