Title: [237422] trunk/Tools
Revision
237422
Author
[email protected]
Date
2018-10-25 12:51:42 -0700 (Thu, 25 Oct 2018)

Log Message

Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
https://bugs.webkit.org/show_bug.cgi?id=190896

Patch by Joseph Pecoraro <[email protected]> on 2018-10-25
Reviewed by Matt Baker.

* Scripts/webkitpy/common/config/watchlist:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (237421 => 237422)


--- trunk/Tools/ChangeLog	2018-10-25 19:17:04 UTC (rev 237421)
+++ trunk/Tools/ChangeLog	2018-10-25 19:51:42 UTC (rev 237422)
@@ -1,3 +1,12 @@
+2018-10-25  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
+        https://bugs.webkit.org/show_bug.cgi?id=190896
+
+        Reviewed by Matt Baker.
+
+        * Scripts/webkitpy/common/config/watchlist:
+
 2018-10-25  Geoffrey Garen  <[email protected]>
 
         HashMap should support selecting a random entry

Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (237421 => 237422)


--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2018-10-25 19:17:04 UTC (rev 237421)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2018-10-25 19:51:42 UTC (rev 237422)
@@ -191,8 +191,11 @@
                         r"|Tools/Scripts/generate-inspector-protocol-bindings.py"
                         r"|Tools/Scripts/webkitpy/inspector",
         },
+        "WebInspectorProtocol": {
+            "filename": r"Source/_javascript_Core/inspector/protocol/",
+        },
         "WebInspectorRecording": {
-            "filename": r"Source/_javascript_Core/inspector/Protocol/Recording\.json"
+            "filename": r"Source/_javascript_Core/inspector/protocol/Recording\.json"
                         r"|Source/WebCore/bindings/js/CallTracer.*"
                         r"|Source/WebCore/inspector/Recording.*"
                         r"|Source/WebInspectorUI/UserInterface/\w*/Recording.*\.js"
@@ -439,6 +442,7 @@
                                  "See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API", ],
         "ANGLE": [ "Note that there are important steps to take when updating ANGLE. "
                    "See http://trac.webkit.org/wiki/UpdatingANGLE", ],
+        "WebInspectorProtocol": [ "This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features." ],
         "WebInspectorGenerator": [ "This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)" ],
         "JSBuiltinsGenerator": [ "This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)" ],
         "WasmJSON": [ "This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at \"Source/_javascript_Core/wasm/wasm.json\" and \"JSTests/wasm/wasm.json\"." ],
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to