Title: [237424] trunk/Source/WebCore
Revision
237424
Author
[email protected]
Date
2018-10-25 12:55:12 -0700 (Thu, 25 Oct 2018)

Log Message

Unreviewed, silence a -Wreturn-type warning

When every return is supposed to be covered by a switch statement, a release assert or CRASH
is required by GCC.

* Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
(WebCore::LibWebRTCCertificateGenerator::keyParamsFromCertificateType):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (237423 => 237424)


--- trunk/Source/WebCore/ChangeLog	2018-10-25 19:53:15 UTC (rev 237423)
+++ trunk/Source/WebCore/ChangeLog	2018-10-25 19:55:12 UTC (rev 237424)
@@ -1,3 +1,13 @@
+2018-10-25  Michael Catanzaro  <[email protected]>
+
+        Unreviewed, silence a -Wreturn-type warning
+
+        When every return is supposed to be covered by a switch statement, a release assert or CRASH
+        is required by GCC.
+
+        * Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
+        (WebCore::LibWebRTCCertificateGenerator::keyParamsFromCertificateType):
+
 2018-10-25  Antoine Quint  <[email protected]>
 
         [Web Animations] Turn Web Animations CSS Integration off by default

Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp (237423 => 237424)


--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp	2018-10-25 19:53:15 UTC (rev 237423)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp	2018-10-25 19:55:12 UTC (rev 237424)
@@ -98,6 +98,8 @@
             return rtc::KeyParams::RSA(info.rsaParameters->modulusLength, info.rsaParameters->publicExponent);
         return rtc::KeyParams::RSA(2048, 65537);
     }
+
+    RELEASE_ASSERT_NOT_REACHED();
 }
 
 void generateCertificate(LibWebRTCProvider& provider, const PeerConnectionBackend::CertificateInformation& info, DOMPromiseDeferred<IDLInterface<RTCCertificate>>&& promise)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to