Title: [237430] trunk/Source/WebInspectorUI
- Revision
- 237430
- Author
- [email protected]
- Date
- 2018-10-25 15:57:45 -0700 (Thu, 25 Oct 2018)
Log Message
Web Inspector: Network: more aggressively snap timing blocks together
https://bugs.webkit.org/show_bug.cgi?id=190439
Reviewed by Timothy Hatcher.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateWaterfallGraph.appendBlock):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
If the time difference between the end of the previous block and the start of this block
would result in less than 2px of space, extend the next block back to the previous block.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (237429 => 237430)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-25 22:23:23 UTC (rev 237429)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-25 22:57:45 UTC (rev 237430)
@@ -1,3 +1,16 @@
+2018-10-25 Devin Rousso <[email protected]>
+
+ Web Inspector: Network: more aggressively snap timing blocks together
+ https://bugs.webkit.org/show_bug.cgi?id=190439
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView.prototype._populateWaterfallGraph.appendBlock):
+ (WI.NetworkTableContentView.prototype._populateWaterfallGraph):
+ If the time difference between the end of the previous block and the start of this block
+ would result in less than 2px of space, extend the next block back to the previous block.
+
2018-10-24 Devin Rousso <[email protected]>
Web Inspector: popovers for function source code are malformed
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (237429 => 237430)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2018-10-25 22:23:23 UTC (rev 237429)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2018-10-25 22:57:45 UTC (rev 237430)
@@ -744,10 +744,15 @@
return;
}
+ let lastEndTimestamp = NaN;
function appendBlock(startTimestamp, endTimestamp, className) {
if (isNaN(startTimestamp) || isNaN(endTimestamp) || endTimestamp - startTimestamp <= 0)
return null;
+ if (Math.abs(startTimestamp - lastEndTimestamp) < secondsPerPixel * 2)
+ startTimestamp = lastEndTimestamp;
+ lastEndTimestamp = endTimestamp;
+
let block = container.appendChild(document.createElement("div"));
block.classList.add("block", className);
positionByStartOffset(block, startTimestamp);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
