Title: [237435] trunk/Source/WebInspectorUI
Revision
237435
Author
[email protected]
Date
2018-10-25 16:55:12 -0700 (Thu, 25 Oct 2018)

Log Message

JSContext Inspector: Broken frontend, DOMAgent is used but does not exist
https://bugs.webkit.org/show_bug.cgi?id=190922
<rdar://problem/45569827>

Patch by Joseph Pecoraro <[email protected]> on 2018-10-25
Reviewed by Devin Rousso.

* UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.requestDocument):
Feature check for agents that may not exist in a JSContext.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (237434 => 237435)


--- trunk/Source/WebInspectorUI/ChangeLog	2018-10-25 23:47:12 UTC (rev 237434)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-10-25 23:55:12 UTC (rev 237435)
@@ -1,3 +1,15 @@
+2018-10-25  Joseph Pecoraro  <[email protected]>
+
+        JSContext Inspector: Broken frontend, DOMAgent is used but does not exist
+        https://bugs.webkit.org/show_bug.cgi?id=190922
+        <rdar://problem/45569827>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Controllers/DOMManager.js:
+        (WI.DOMManager.prototype.requestDocument):
+        Feature check for agents that may not exist in a JSContext.
+
 2018-10-25  Devin Rousso  <[email protected]>
 
         Web Inspector: add corner rounding to the network timing "blocks"

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js (237434 => 237435)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js	2018-10-25 23:47:12 UTC (rev 237434)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js	2018-10-25 23:55:12 UTC (rev 237435)
@@ -82,7 +82,8 @@
             this._pendingDocumentRequestCallbacks = null;
         }
 
-        DOMAgent.getDocument(onDocumentAvailable.bind(this));
+        if (window.DOMAgent)
+            DOMAgent.getDocument(onDocumentAvailable.bind(this));
     }
 
     ensureDocument()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to