Title: [237441] trunk/Source/WebCore
- Revision
- 237441
- Author
- [email protected]
- Date
- 2018-10-25 17:39:36 -0700 (Thu, 25 Oct 2018)
Log Message
Fix build after r237431 for platforms that don't support FULLSCREEN_API
Need the bug URL (OOPS!).
Reviewed by Joseph Pecoraro.
No new tests. No change in behavior.
* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::addEventListenersToNode):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (237440 => 237441)
--- trunk/Source/WebCore/ChangeLog 2018-10-26 00:21:00 UTC (rev 237440)
+++ trunk/Source/WebCore/ChangeLog 2018-10-26 00:39:36 UTC (rev 237441)
@@ -1,5 +1,16 @@
2018-10-25 Devin Rousso <[email protected]>
+ Fix build after r237431 for platforms that don't support FULLSCREEN_API
+
+ Reviewed by Joseph Pecoraro.
+
+ No new tests. No change in behavior.
+
+ * inspector/agents/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::addEventListenersToNode):
+
+2018-10-25 Devin Rousso <[email protected]>
+
Web Inspector: display fullscreen enter/exit events in Timelines and Network node waterfalls
https://bugs.webkit.org/show_bug.cgi?id=189874
<rdar://problem/44700000>
Modified: trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp (237440 => 237441)
--- trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp 2018-10-26 00:21:00 UTC (rev 237440)
+++ trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp 2018-10-26 00:39:36 UTC (rev 237441)
@@ -246,8 +246,10 @@
RefPtr<JSON::Object> data = ""
+#if ENABLE(FULLSCREEN_API)
if (event.type() == eventNames().webkitfullscreenchangeEvent)
data->setBoolean("enabled"_s, !!node->document().webkitFullscreenElement());
+#endif // ENABLE(FULLSCREEN_API)
auto timestamp = m_domAgent.m_environment.executionStopwatch()->elapsedTime().seconds();
m_domAgent.m_frontendDispatcher->didFireEvent(nodeId, event.type(), timestamp, data->size() ? WTFMove(data) : nullptr);
@@ -2149,10 +2151,12 @@
node.addEventListener(eventName, callback.copyRef(), false);
};
- if (is<Document>(node))
+#if ENABLE(FULLSCREEN_API)
+ if (is<Document>(node) || is<HTMLMediaElement>(node))
createEventListener(eventNames().webkitfullscreenchangeEvent);
- else if (is<HTMLMediaElement>(node)) {
- createEventListener(eventNames().webkitfullscreenchangeEvent);
+#endif // ENABLE(FULLSCREEN_API)
+
+ if (is<HTMLMediaElement>(node)) {
createEventListener(eventNames().abortEvent);
createEventListener(eventNames().canplayEvent);
createEventListener(eventNames().canplaythroughEvent);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
