Title: [237494] releases/WebKitGTK/webkit-2.22
Revision
237494
Author
[email protected]
Date
2018-10-27 14:17:21 -0700 (Sat, 27 Oct 2018)

Log Message

Merged r235177 - The DFG CFGSimplification phase shouldn’t jettison a block when it’s the target of both branch directions.
https://bugs.webkit.org/show_bug.cgi?id=188298
<rdar://problem/42888427>

Reviewed by Saam Barati.

JSTests:

* stress/bug-188298.js: Added.

Source/_javascript_Core:

In the event that both targets of a Branch is the same block, then even if we'll
always take one path of the branch, the other target is not unreachable because
it is the same target as the one in the taken path.  Hence, it should not be
jettisoned.

* _javascript_Core.xcodeproj/project.pbxproj:
- Added DFGCFG.h which is in use and should have been added to the project.
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.22/JSTests/ChangeLog (237493 => 237494)


--- releases/WebKitGTK/webkit-2.22/JSTests/ChangeLog	2018-10-27 15:34:35 UTC (rev 237493)
+++ releases/WebKitGTK/webkit-2.22/JSTests/ChangeLog	2018-10-27 21:17:21 UTC (rev 237494)
@@ -1,3 +1,13 @@
+2018-08-22  Mark Lam  <[email protected]>
+
+        The DFG CFGSimplification phase shouldn’t jettison a block when it’s the target of both branch directions.
+        https://bugs.webkit.org/show_bug.cgi?id=188298
+        <rdar://problem/42888427>
+
+        Reviewed by Saam Barati.
+
+        * stress/bug-188298.js: Added.
+
 2018-09-19  Saam barati  <[email protected]>
 
         AI rule for MultiPutByOffset executes its effects in the wrong order

Modified: releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog (237493 => 237494)


--- releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog	2018-10-27 15:34:35 UTC (rev 237493)
+++ releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog	2018-10-27 21:17:21 UTC (rev 237494)
@@ -1,3 +1,21 @@
+2018-08-22  Mark Lam  <[email protected]>
+
+        The DFG CFGSimplification phase shouldn’t jettison a block when it’s the target of both branch directions.
+        https://bugs.webkit.org/show_bug.cgi?id=188298
+        <rdar://problem/42888427>
+
+        Reviewed by Saam Barati.
+
+        In the event that both targets of a Branch is the same block, then even if we'll
+        always take one path of the branch, the other target is not unreachable because
+        it is the same target as the one in the taken path.  Hence, it should not be
+        jettisoned.
+
+        * _javascript_Core.xcodeproj/project.pbxproj:
+        - Added DFGCFG.h which is in use and should have been added to the project.
+        * dfg/DFGCFGSimplificationPhase.cpp:
+        (JSC::DFG::CFGSimplificationPhase::run):
+
 2018-09-21  Tomas Popela  <[email protected]>
 
         [ARM] Build broken on armv7hl after r235517
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to