Title: [237578] trunk/Source/WebInspectorUI
- Revision
- 237578
- Author
- [email protected]
- Date
- 2018-10-29 20:26:57 -0700 (Mon, 29 Oct 2018)
Log Message
Web Inspector: Flash views with red outline on initial layout
https://bugs.webkit.org/show_bug.cgi?id=191048
Reviewed by Devin Rousso.
* UserInterface/Views/View.js:
(WI.View.prototype._layoutSubtree):
(WI.View.prototype._drawLayoutFlashingOutline):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (237577 => 237578)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-30 02:58:51 UTC (rev 237577)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-30 03:26:57 UTC (rev 237578)
@@ -1,3 +1,14 @@
+2018-10-29 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Flash views with red outline on initial layout
+ https://bugs.webkit.org/show_bug.cgi?id=191048
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/View.js:
+ (WI.View.prototype._layoutSubtree):
+ (WI.View.prototype._drawLayoutFlashingOutline):
+
2018-10-29 Devin Rousso <[email protected]>
Web Inspector: Canvas: show warning when path moves offscreen
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/View.js (237577 => 237578)
--- trunk/Source/WebInspectorUI/UserInterface/Views/View.js 2018-10-30 02:58:51 UTC (rev 237577)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/View.js 2018-10-30 03:26:57 UTC (rev 237578)
@@ -266,6 +266,7 @@
{
this._dirty = false;
this._dirtyDescendantsCount = 0;
+ let isInitialLayout = !this._didInitialLayout;
if (!this._didInitialLayout) {
this.initialLayout();
@@ -278,7 +279,7 @@
this.layout();
if (WI.settings.enableLayoutFlashing.value)
- this._drawLayoutFlashingOutline();
+ this._drawLayoutFlashingOutline(isInitialLayout);
for (let view of this._subviews) {
view._setLayoutReason(this._layoutReason);
@@ -296,7 +297,7 @@
this._layoutReason = layoutReason || WI.View.LayoutReason.Dirty;
}
- _drawLayoutFlashingOutline()
+ _drawLayoutFlashingOutline(isInitialLayout)
{
if (this._layoutFlashingTimeout)
clearTimeout(this._layoutFlashingTimeout);
@@ -303,7 +304,8 @@
else
this._layoutFlashingPreviousOutline = this._element.style.outline;
- this._element.style.outline = "1px solid hsla(39, 100%, 51%, 0.8)";
+ let hue = isInitialLayout ? 20 : 40;
+ this._element.style.outline = `1px solid hsla(${hue}, 100%, 51%, 0.8)`;
this._layoutFlashingTimeout = setTimeout(() => {
if (this._element)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
