Diff
Modified: trunk/LayoutTests/ChangeLog (237590 => 237591)
--- trunk/LayoutTests/ChangeLog 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/ChangeLog 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,5 +1,66 @@
2018-10-30 Sihui Liu <[email protected]>
+ Add a deprecation warning to console for Web SQL
+ https://bugs.webkit.org/show_bug.cgi?id=190936
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline the tests that are affected by the added console message.
+
+ * fast/dom/MutationObserver/database-callback-delivery-expected.txt:
+ * fast/frames/sandboxed-iframe-storage-expected.txt:
+ * fast/history/page-cache-webdatabase-no-transaction-db-expected.txt:
+ * http/tests/security/cross-origin-websql-allowed-expected.txt:
+ * http/tests/security/cross-origin-websql-expected.txt:
+ * http/tests/security/same-origin-websql-blocked-expected.txt:
+ * http/tests/security/storage-blocking-loosened-websql-expected.txt:
+ * http/tests/security/storage-blocking-strengthened-websql-expected.txt:
+ * http/tests/storage/callbacks-are-called-in-correct-context-expected.txt:
+ * inspector/runtime/CommandLineAPI-inspect-expected.txt:
+ * js/dom/callback-function-with-handle-event-expected.txt:
+ * js/dom/exceptions-thrown-in-callbacks-expected.txt:
+ * storage/websql/alter-to-info-table-expected.txt:
+ * storage/websql/change-version-expected.txt:
+ * storage/websql/change-version-handle-reuse-expected.txt:
+ * storage/websql/change-version-no-crash-on-preflight-failure-expected.txt:
+ * storage/websql/close-during-stress-test-expected.txt:
+ * storage/websql/database-lock-after-reload-expected.txt:
+ * storage/websql/empty-statement-expected.txt:
+ * storage/websql/execute-sql-args-expected.txt:
+ * storage/websql/execute-sql-rowsAffected-expected.txt:
+ * storage/websql/executesql-accepts-only-one-statement-expected.txt:
+ * storage/websql/hash-change-with-xhr-expected.txt:
+ * storage/websql/multiple-databases-garbage-collection-expected.txt:
+ * storage/websql/multiple-transactions-expected.txt:
+ * storage/websql/multiple-transactions-on-different-handles-expected.txt:
+ * storage/websql/null-callbacks-expected.txt:
+ * storage/websql/open-database-creation-callback-expected.txt:
+ * storage/websql/open-database-creation-callback-isolated-world-expected.txt:
+ * storage/websql/open-database-empty-version-expected.txt:
+ * storage/websql/open-database-expand-quota-expected.txt:
+ * storage/websql/open-database-over-quota-expected.txt:
+ * storage/websql/open-database-set-empty-version-expected.txt:
+ * storage/websql/open-database-while-transaction-in-progress-expected.txt:
+ * storage/websql/private-browsing-noread-nowrite-expected.txt:
+ * storage/websql/read-and-write-transactions-dont-run-together-expected.txt:
+ * storage/websql/read-transactions-running-concurrently-expected.txt:
+ * storage/websql/sql-data-types-expected.txt:
+ * storage/websql/statement-error-callback-expected.txt:
+ * storage/websql/statement-error-callback-isolated-world-expected.txt:
+ * storage/websql/statement-success-callback-isolated-world-expected.txt:
+ * storage/websql/success-callback-expected.txt:
+ * storage/websql/success-callback-when-page-defers-loading-expected.txt:
+ * storage/websql/test-authorizer-expected.txt:
+ * storage/websql/transaction-callback-exception-crash-expected.txt:
+ * storage/websql/transaction-callback-isolated-world-expected.txt:
+ * storage/websql/transaction-database-expand-quota-expected.txt:
+ * storage/websql/transaction-error-callback-expected.txt:
+ * storage/websql/transaction-error-callback-isolated-world-expected.txt:
+ * storage/websql/transaction-prototype-expected.txt:
+ * storage/websql/transaction-success-callback-isolated-world-expected.txt:
+
+2018-10-30 Sihui Liu <[email protected]>
+
IndexedDB: iteration of cursors skip records if updated or deleted
https://bugs.webkit.org/show_bug.cgi?id=190917
<rdar://problem/35250410>
Modified: trunk/LayoutTests/fast/dom/MutationObserver/database-callback-delivery-expected.txt (237590 => 237591)
--- trunk/LayoutTests/fast/dom/MutationObserver/database-callback-delivery-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/fast/dom/MutationObserver/database-callback-delivery-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 21: Web SQL is deprecated. Please use IndexedDB instead.
Testing mutations are delivered following Database transaction callbacks.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/fast/frames/sandboxed-iframe-storage-expected.txt (237590 => 237591)
--- trunk/LayoutTests/fast/frames/sandboxed-iframe-storage-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/fast/frames/sandboxed-iframe-storage-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 1: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 1: Web SQL is deprecated. Please use IndexedDB instead.
This test verifies that a sandboxed iframe does not have access to any session storage, local storage or database.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/fast/history/page-cache-webdatabase-no-transaction-db-expected.txt (237590 => 237591)
--- trunk/LayoutTests/fast/history/page-cache-webdatabase-no-transaction-db-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/fast/history/page-cache-webdatabase-no-transaction-db-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 32: Web SQL is deprecated. Please use IndexedDB instead.
Tests that a page with an open WebDatabase with no pending transaction goes into the page cache.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/http/tests/security/cross-origin-websql-allowed-expected.txt (237590 => 237591)
--- trunk/LayoutTests/http/tests/security/cross-origin-websql-allowed-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/http/tests/security/cross-origin-websql-allowed-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
This iframe should not return any errors:
Modified: trunk/LayoutTests/http/tests/security/cross-origin-websql-expected.txt (237590 => 237591)
--- trunk/LayoutTests/http/tests/security/cross-origin-websql-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/http/tests/security/cross-origin-websql-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
This iframe should return a security error:
Modified: trunk/LayoutTests/http/tests/security/same-origin-websql-blocked-expected.txt (237590 => 237591)
--- trunk/LayoutTests/http/tests/security/same-origin-websql-blocked-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/http/tests/security/same-origin-websql-blocked-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
This iframe should return a security error:
Modified: trunk/LayoutTests/http/tests/security/storage-blocking-loosened-websql-expected.txt (237590 => 237591)
--- trunk/LayoutTests/http/tests/security/storage-blocking-loosened-websql-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/http/tests/security/storage-blocking-loosened-websql-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 12: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 22: Web SQL is deprecated. Please use IndexedDB instead.
This iframe should return only one security error:
Modified: trunk/LayoutTests/http/tests/security/storage-blocking-strengthened-websql-expected.txt (237590 => 237591)
--- trunk/LayoutTests/http/tests/security/storage-blocking-strengthened-websql-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/http/tests/security/storage-blocking-strengthened-websql-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 12: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 22: Web SQL is deprecated. Please use IndexedDB instead.
This iframe should return only one security error:
Modified: trunk/LayoutTests/http/tests/storage/callbacks-are-called-in-correct-context-expected.txt (237590 => 237591)
--- trunk/LayoutTests/http/tests/storage/callbacks-are-called-in-correct-context-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/http/tests/storage/callbacks-are-called-in-correct-context-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 4: Web SQL is deprecated. Please use IndexedDB instead.
--------
Modified: trunk/LayoutTests/inspector/runtime/CommandLineAPI-inspect-expected.txt (237590 => 237591)
--- trunk/LayoutTests/inspector/runtime/CommandLineAPI-inspect-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/inspector/runtime/CommandLineAPI-inspect-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 1: Web SQL is deprecated. Please use IndexedDB instead.
Tests for CommandLineAPI.prototype.inspect with different object types.
Modified: trunk/LayoutTests/js/dom/callback-function-with-handle-event-expected.txt (237590 => 237591)
--- trunk/LayoutTests/js/dom/callback-function-with-handle-event-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/js/dom/callback-function-with-handle-event-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 32: Web SQL is deprecated. Please use IndexedDB instead.
When a JS callback is a function, it should be called. If the function has another function as its handleEvent property, that function should not be called.
PASS The callback function was called directly.
Modified: trunk/LayoutTests/js/dom/exceptions-thrown-in-callbacks-expected.txt (237590 => 237591)
--- trunk/LayoutTests/js/dom/exceptions-thrown-in-callbacks-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/js/dom/exceptions-thrown-in-callbacks-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
CONSOLE MESSAGE: line 17: PASS: toString called on exception value thrown from event handler
CONSOLE MESSAGE: line 23: PASS: toString called on exception value thrown from sql transaction callback
CONSOLE MESSAGE: line 33: PASS: toString called on exception value thrown from sql error callback
Modified: trunk/LayoutTests/storage/websql/alter-to-info-table-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/alter-to-info-table-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/alter-to-info-table-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
This tests that a tricky way to setup your own info table fails.
CREATE TABLE statement succeeded.
CREATE TEMP TABLE statement succeeded.
Modified: trunk/LayoutTests/storage/websql/change-version-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/change-version-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/change-version-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,7 @@
+CONSOLE MESSAGE: line 63: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 64: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 86: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 45: Web SQL is deprecated. Please use IndexedDB instead.
This test verifies that the JS database.changeVersion() function works as expected.
Finished tests with version 3; expected version: 3
TEST COMPLETE
Modified: trunk/LayoutTests/storage/websql/change-version-handle-reuse-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/change-version-handle-reuse-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/change-version-handle-reuse-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
This tests that a database can be accessed after changing its version. You should see an error about FooBar table below, not about mismatching versions.
changeVersion: transaction callback
changeVersion: success callback
Modified: trunk/LayoutTests/storage/websql/change-version-no-crash-on-preflight-failure-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/change-version-no-crash-on-preflight-failure-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/change-version-no-crash-on-preflight-failure-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 21: Web SQL is deprecated. Please use IndexedDB instead.
This test verifies that no assertion is triggered when changeVersion()'s preflight step fails.
PASS: db.changeVersion() failed as expected, and no assertions were triggered.
Modified: trunk/LayoutTests/storage/websql/close-during-stress-test-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/close-during-stress-test-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/close-during-stress-test-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 9: Web SQL is deprecated. Please use IndexedDB instead.
Should not crash or cause an assertion failure.
A _javascript_ failure on the console is expected, however, as the global object is cleared when closing a frame. It actually helps to cause database activity by throwing an exception from a callback.
Modified: trunk/LayoutTests/storage/websql/database-lock-after-reload-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/database-lock-after-reload-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/database-lock-after-reload-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 46: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 39: Web SQL is deprecated. Please use IndexedDB instead.
Inserting some data
Test part 2 Complete
Modified: trunk/LayoutTests/storage/websql/empty-statement-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/empty-statement-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/empty-statement-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,2 +1,3 @@
+CONSOLE MESSAGE: line 25: Web SQL is deprecated. Please use IndexedDB instead.
Executed an empty statement. If you didn't see a crash or assertion, the test passed.
Modified: trunk/LayoutTests/storage/websql/execute-sql-args-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/execute-sql-args-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/execute-sql-args-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
PASS. executeSql(null) did not throw an exception
PASS. executeSql(undefined) did not throw an exception
PASS. executeSql(0) did not throw an exception
Modified: trunk/LayoutTests/storage/websql/execute-sql-rowsAffected-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/execute-sql-rowsAffected-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/execute-sql-rowsAffected-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 25: Web SQL is deprecated. Please use IndexedDB instead.
This test tests that SQLResultSet.rowsAffected attribute is correct in success callback for executeSql().
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/storage/websql/executesql-accepts-only-one-statement-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/executesql-accepts-only-one-statement-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/executesql-accepts-only-one-statement-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 54: Web SQL is deprecated. Please use IndexedDB instead.
This test tests that executeSql() fails when called with a string that has more than one valid statement in it.
Test passed.
Modified: trunk/LayoutTests/storage/websql/hash-change-with-xhr-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/hash-change-with-xhr-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/hash-change-with-xhr-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
Changing the hash to create history entries.
Db is warmed up
Test Complete, SUCCESS
Modified: trunk/LayoutTests/storage/websql/multiple-databases-garbage-collection-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/multiple-databases-garbage-collection-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/multiple-databases-garbage-collection-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
This test opens two databases, queues up a series of operations on both, then "forgets" about one of them. After forcing GC, resources associated with that database should be freed gracefully.
Forgotten Database Transaction Complete
Persistent Database Transaction Complete
Modified: trunk/LayoutTests/storage/websql/multiple-transactions-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/multiple-transactions-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/multiple-transactions-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
This is a test to see if the database API allows multiple transactions to be queued on the same database at once:
Transaction 1 Started
Transaction 1 Succeeded
Modified: trunk/LayoutTests/storage/websql/multiple-transactions-on-different-handles-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/multiple-transactions-on-different-handles-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/multiple-transactions-on-different-handles-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,6 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
This is a test to see if queueing up multiple transactions on different handles to the same database results in a deadlock.
db1 read statement succeeded
db1 write statement succeeded
Modified: trunk/LayoutTests/storage/websql/null-callbacks-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/null-callbacks-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/null-callbacks-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,2 +1,3 @@
+CONSOLE MESSAGE: line 19: Web SQL is deprecated. Please use IndexedDB instead.
This test checks that 'null' can be used wherever we expect an optional callback.
PASS
Modified: trunk/LayoutTests/storage/websql/open-database-creation-callback-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/open-database-creation-callback-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/open-database-creation-callback-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,7 @@
+CONSOLE MESSAGE: line 30: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 56: Web SQL is deprecated. Please use IndexedDB instead.
CONSOLE MESSAGE: line 56: unable to open database, version mismatch, '1.0' does not match the currentVersion of ''
+CONSOLE MESSAGE: line 69: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 70: Web SQL is deprecated. Please use IndexedDB instead.
This test tests openDatabase()'s creation callback.
Modified: trunk/LayoutTests/storage/websql/open-database-creation-callback-isolated-world-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/open-database-creation-callback-isolated-world-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/open-database-creation-callback-isolated-world-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 42: Web SQL is deprecated. Please use IndexedDB instead.
ALERT: undefined
ALERT: PASS: document.body.bar visible in a callback created in this world.
This test tests that the openDatabase() creation callback is called in the right world.
Modified: trunk/LayoutTests/storage/websql/open-database-empty-version-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/open-database-empty-version-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/open-database-empty-version-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,2 +1,3 @@
+CONSOLE MESSAGE: line 9: Web SQL is deprecated. Please use IndexedDB instead.
This tests that calling openDatabase with an empty version string does not cause an exception to be thrown.
SUCCESS! Did not throw an exception.
Modified: trunk/LayoutTests/storage/websql/open-database-expand-quota-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/open-database-expand-quota-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/open-database-expand-quota-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 13: Web SQL is deprecated. Please use IndexedDB instead.
UI DELEGATE DATABASE CALLBACK: increased quota to 8000000
This tests that calling openDatabase with a size over 5MB doesn't assert on debug builds, and will increase the quota to accommodate the requested size whennot exceeding a max limit of 10M.
PASS
Modified: trunk/LayoutTests/storage/websql/open-database-over-quota-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/open-database-over-quota-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/open-database-over-quota-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,2 +1,3 @@
+CONSOLE MESSAGE: line 11: Web SQL is deprecated. Please use IndexedDB instead.
This tests that calling openDatabase with a size greater or equal to the test max quota limit of 5MB doesn't assert on debug builds.
PASS
Modified: trunk/LayoutTests/storage/websql/open-database-set-empty-version-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/open-database-set-empty-version-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/open-database-set-empty-version-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 11: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 13: Web SQL is deprecated. Please use IndexedDB instead.
CONSOLE MESSAGE: line 13: unable to open database, version mismatch, 'test' does not match the currentVersion of ''
This tests that calling openDatabase with an empty version string sets the current version of that database to the empty string and subsequent attempts to open the database with a different expected version throw an exception.
SUCCESS, an exception was thrown. InvalidStateError: The object is in an invalid state.
Modified: trunk/LayoutTests/storage/websql/open-database-while-transaction-in-progress-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/open-database-while-transaction-in-progress-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/open-database-while-transaction-in-progress-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
This is a test to see if opening a database while a transaction is running on a different handle to the same database results in a deadlock.
openDatabase() succeeded.
Modified: trunk/LayoutTests/storage/websql/private-browsing-noread-nowrite-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/private-browsing-noread-nowrite-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/private-browsing-noread-nowrite-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 92: Web SQL is deprecated. Please use IndexedDB instead.
This test makes sure that attempts to change the database during private browsing fail.
Setup statement 1 completed successfully
Setup statement 2 completed successfully
Modified: trunk/LayoutTests/storage/websql/read-and-write-transactions-dont-run-together-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/read-and-write-transactions-dont-run-together-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/read-and-write-transactions-dont-run-together-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,6 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
This test tests that read and write transactions on different handles to the same database don't run together.
Transaction successful.
Transaction successful.
Modified: trunk/LayoutTests/storage/websql/read-transactions-running-concurrently-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/read-transactions-running-concurrently-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/read-transactions-running-concurrently-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 18: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 18: Web SQL is deprecated. Please use IndexedDB instead.
This test tests that two read-only transactions on different handles to the same database run concurrently.
Read transactions running concurrently.
Modified: trunk/LayoutTests/storage/websql/sql-data-types-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/sql-data-types-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/sql-data-types-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 82: Web SQL is deprecated. Please use IndexedDB instead.
PASS: property 'timestamp' ok, type was number
PASS: property 'id' ok, type was number
PASS: property 'real' ok, type was number
Modified: trunk/LayoutTests/storage/websql/statement-error-callback-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/statement-error-callback-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/statement-error-callback-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 64: Web SQL is deprecated. Please use IndexedDB instead.
CONSOLE MESSAGE: line 67: Exception in statement error callback
This test confirms that a transaction is immediately rolled back if and only if a statement's error callback throws an exception, returns true, or doesn't return any value.
PASS - the transaction error callback was invoked.
Modified: trunk/LayoutTests/storage/websql/statement-error-callback-isolated-world-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/statement-error-callback-isolated-world-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/statement-error-callback-isolated-world-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 45: Web SQL is deprecated. Please use IndexedDB instead.
ALERT: undefined
ALERT: PASS: document.body.bar visible in a callback created in this world.
This test tests that the statement error callback is called in the right world.
Modified: trunk/LayoutTests/storage/websql/statement-success-callback-isolated-world-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/statement-success-callback-isolated-world-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/statement-success-callback-isolated-world-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 45: Web SQL is deprecated. Please use IndexedDB instead.
ALERT: undefined
ALERT: PASS: document.body.bar visible in a callback created in this world.
This test tests that the statement success callback is called in the right world.
Modified: trunk/LayoutTests/storage/websql/success-callback-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/success-callback-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/success-callback-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 40: Web SQL is deprecated. Please use IndexedDB instead.
This test confirms that a successful transaction - both with and without a statement - receives its successCallback
Transaction succeeded - Transaction with one statement
Transaction succeeded - Empty transaction
Modified: trunk/LayoutTests/storage/websql/success-callback-when-page-defers-loading-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/success-callback-when-page-defers-loading-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/success-callback-when-page-defers-loading-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 18: Web SQL is deprecated. Please use IndexedDB instead.
This tests that a SQL success callback completes when the page defers loading.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/storage/websql/test-authorizer-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/test-authorizer-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/test-authorizer-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
This test tests the database authorizer.
SQLITE_CREATE_TABLE statement succeeded.
SQLITE_CREATE_INDEX statement succeeded.
Modified: trunk/LayoutTests/storage/websql/transaction-callback-exception-crash-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/transaction-callback-exception-crash-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/transaction-callback-exception-crash-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,2 +1,3 @@
+CONSOLE MESSAGE: line 9: Web SQL is deprecated. Please use IndexedDB instead.
CONSOLE MESSAGE: line 13: TransactionCallbackError
If WebKit doesn't crash, this test has passed
Modified: trunk/LayoutTests/storage/websql/transaction-callback-isolated-world-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/transaction-callback-isolated-world-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/transaction-callback-isolated-world-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 43: Web SQL is deprecated. Please use IndexedDB instead.
ALERT: undefined
ALERT: PASS: document.body.bar visible in a callback created in this world.
This test tests that the transaction callback is called in the right world.
Modified: trunk/LayoutTests/storage/websql/transaction-database-expand-quota-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/transaction-database-expand-quota-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/transaction-database-expand-quota-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 48: Web SQL is deprecated. Please use IndexedDB instead.
UI DELEGATE DATABASE CALLBACK: exceededDatabaseQuotaForSecurityOrigin:{file, , 0} database:ExpandedQuotaTransaction
UI DELEGATE DATABASE CALLBACK: increased quota to 209715
UI DELEGATE DATABASE CALLBACK: exceededDatabaseQuotaForSecurityOrigin:{file, , 0} database:ExpandedQuotaTransaction
Modified: trunk/LayoutTests/storage/websql/transaction-error-callback-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/transaction-error-callback-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/transaction-error-callback-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 76: Web SQL is deprecated. Please use IndexedDB instead.
CONSOLE MESSAGE: line 63: [object Object]
CONSOLE MESSAGE: line 63: [object Object]
This test confirms that SQLTransactionErrorCallback is invoked correctly and regardless of its output, the transaction is always rolled back on failure.
Modified: trunk/LayoutTests/storage/websql/transaction-error-callback-isolated-world-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/transaction-error-callback-isolated-world-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/transaction-error-callback-isolated-world-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 45: Web SQL is deprecated. Please use IndexedDB instead.
ALERT: undefined
ALERT: PASS: document.body.bar visible in a callback created in this world.
This test tests that the transaction error callback is called in the right world.
Modified: trunk/LayoutTests/storage/websql/transaction-prototype-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/transaction-prototype-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/transaction-prototype-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 9: Web SQL is deprecated. Please use IndexedDB instead.
Tests that it is possible to access SQLTransaction.constructor.prototype and that it is correct
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/storage/websql/transaction-success-callback-isolated-world-expected.txt (237590 => 237591)
--- trunk/LayoutTests/storage/websql/transaction-success-callback-isolated-world-expected.txt 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/LayoutTests/storage/websql/transaction-success-callback-isolated-world-expected.txt 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 43: Web SQL is deprecated. Please use IndexedDB instead.
ALERT: undefined
ALERT: PASS: document.body.bar visible in a callback created in this world.
This test tests that the transaction success callback is called in the right world.
Modified: trunk/Source/WebCore/ChangeLog (237590 => 237591)
--- trunk/Source/WebCore/ChangeLog 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/Source/WebCore/ChangeLog 2018-10-30 17:32:05 UTC (rev 237591)
@@ -1,5 +1,17 @@
2018-10-30 Sihui Liu <[email protected]>
+ Add a deprecation warning to console for Web SQL
+ https://bugs.webkit.org/show_bug.cgi?id=190936
+
+ Reviewed by Ryosuke Niwa.
+
+ No new tests. Just adding a console message.
+
+ * Modules/webdatabase/DOMWindowWebDatabase.cpp:
+ (WebCore::DOMWindowWebDatabase::openDatabase):
+
+2018-10-30 Sihui Liu <[email protected]>
+
IndexedDB: iteration of cursors skip records if updated or deleted
https://bugs.webkit.org/show_bug.cgi?id=190917
<rdar://problem/35250410>
Modified: trunk/Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp (237590 => 237591)
--- trunk/Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp 2018-10-30 17:11:39 UTC (rev 237590)
+++ trunk/Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp 2018-10-30 17:32:05 UTC (rev 237591)
@@ -45,6 +45,8 @@
auto* document = window.document();
if (!document)
return Exception { SecurityError };
+ document->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "Web SQL is deprecated. Please use IndexedDB instead.");
+
auto& securityOrigin = document->securityOrigin();
if (!securityOrigin.canAccessDatabase(document->topOrigin()))
return Exception { SecurityError };
