Title: [237675] trunk/LayoutTests
- Revision
- 237675
- Author
- [email protected]
- Date
- 2018-11-01 02:27:58 -0700 (Thu, 01 Nov 2018)
Log Message
MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778
<rdar://problem/45703574>
Patch by YUHAN WU <[email protected]> on 2018-11-01
Reviewed by Youenn Fablet.
Remove share FileReader object between three asynchronous tests which might cause flaky failure.
We will need to fix all the falky failures in this test after we implement timeslice.
* http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (237674 => 237675)
--- trunk/LayoutTests/ChangeLog 2018-11-01 08:51:45 UTC (rev 237674)
+++ trunk/LayoutTests/ChangeLog 2018-11-01 09:27:58 UTC (rev 237675)
@@ -1,3 +1,16 @@
+2018-11-01 YUHAN WU <[email protected]>
+
+ MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
+ https://bugs.webkit.org/show_bug.cgi?id=190778
+ <rdar://problem/45703574>
+
+ Reviewed by Youenn Fablet.
+
+ Remove share FileReader object between three asynchronous tests which might cause flaky failure.
+ We will need to fix all the falky failures in this test after we implement timeslice.
+
+ * http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:
+
2018-10-31 Devin Rousso <[email protected]>
Web Inspector: Canvas: create a setting for auto-recording newly created contexts
Modified: trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html (237674 => 237675)
--- trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html 2018-11-01 08:51:45 UTC (rev 237674)
+++ trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html 2018-11-01 09:27:58 UTC (rev 237675)
@@ -11,7 +11,6 @@
</canvas>
<script>
var context;
- const reader = new FileReader();
function createVideoStream() {
const canvas = document.getElementById("canvas");
@@ -27,6 +26,7 @@
async_test(t => {
const video = createVideoStream();
const recorder = new MediaRecorder(video);
+ const reader = new FileReader();
recorder._ondataavailable_ = t.step_func(blobEvent => {
reader.readAsText(blobEvent.data);
@@ -51,6 +51,7 @@
const audio = dest.stream;
osc.connect(dest);
const recorder = new MediaRecorder(audio);
+ const reader = new FileReader();
recorder._ondataavailable_ = t.step_func(blobEvent => {
reader.readAsText(blobEvent.data);
@@ -82,6 +83,7 @@
video.addTrack(audio.getAudioTracks()[0]);
assert_equals(video.getAudioTracks().length, 1, "video mediastream starts with one audio track");
const recorder = new MediaRecorder(video);
+ const reader = new FileReader();
recorder._ondataavailable_ = t.step_func(blobEvent => {
reader.readAsText(blobEvent.data);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
