Title: [237681] trunk/LayoutTests
Revision
237681
Author
[email protected]
Date
2018-11-01 09:11:28 -0700 (Thu, 01 Nov 2018)

Log Message

Unreviewed test fix after r237670.

* inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt:
* inspector/canvas/setRecordingAutoCaptureFrameCount.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (237680 => 237681)


--- trunk/LayoutTests/ChangeLog	2018-11-01 15:19:14 UTC (rev 237680)
+++ trunk/LayoutTests/ChangeLog	2018-11-01 16:11:28 UTC (rev 237681)
@@ -1,3 +1,12 @@
+2018-11-01  Devin Rousso  <[email protected]>
+
+        Unreviewed test fix after r237670.
+
+        * inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt:
+        * inspector/canvas/setRecordingAutoCaptureFrameCount.html:
+        Make the `CanvasAdded` event listener synchronous, so it won't miss the `RecordingStarted`
+        or `RecordingStopped` events, since `awaitEvent` evaluates on the next tick.
+
 2018-10-31  Zalan Bujtas  <[email protected]>
 
         [LFC][IFC] Add support for inline-block elements.

Modified: trunk/LayoutTests/inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt (237680 => 237681)


--- trunk/LayoutTests/inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt	2018-11-01 15:19:14 UTC (rev 237680)
+++ trunk/LayoutTests/inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt	2018-11-01 16:11:28 UTC (rev 237681)
@@ -6,6 +6,7 @@
 PASS: Canvas should have no finished recordings.
 
 -- Running test case: Canvas.setRecordingAutoCaptureFrameCount.2D.Single
+PASS: Recording started.
 PASS: Recording stopped.
 PASS: Recording should have one frame.
 PASS: Recording should have one action.
@@ -12,6 +13,7 @@
 PASS: Canvas should have one finished recording.
 
 -- Running test case: Canvas.setRecordingAutoCaptureFrameCount.2D.Multiple
+PASS: Recording started.
 PASS: Canvas should have no finished recordings.
 PASS: Canvas should be actively recording.
 PASS: Recording should have 2 frames.
@@ -20,6 +22,7 @@
 PASS: Canvas should have no finished recordings.
 
 -- Running test case: Canvas.setRecordingAutoCaptureFrameCount.WebGL.Single
+PASS: Recording started.
 PASS: Recording stopped.
 PASS: Recording should have one frame.
 PASS: Recording should have one action.
@@ -26,6 +29,7 @@
 PASS: Canvas should have one finished recording.
 
 -- Running test case: Canvas.setRecordingAutoCaptureFrameCount.WebGL.Multiple
+PASS: Recording started.
 PASS: Canvas should have no finished recordings.
 PASS: Canvas should be actively recording.
 PASS: Recording should have 2 frames.

Modified: trunk/LayoutTests/inspector/canvas/setRecordingAutoCaptureFrameCount.html (237680 => 237681)


--- trunk/LayoutTests/inspector/canvas/setRecordingAutoCaptureFrameCount.html	2018-11-01 15:19:14 UTC (rev 237680)
+++ trunk/LayoutTests/inspector/canvas/setRecordingAutoCaptureFrameCount.html	2018-11-01 16:11:28 UTC (rev 237681)
@@ -77,9 +77,9 @@
                     handleRecordingStopped(canvas, event.data.recording);
                 }
 
-                WI.canvasManager.awaitEvent(WI.CanvasManager.Event.CanvasAdded)
-                .then((event) => {
+                WI.canvasManager.singleFireEventListener(WI.CanvasManager.Event.CanvasAdded, (event) => {
                     canvas = event.data.canvas;
+                    InspectorTest.assert(!canvas.recordingActive)
 
                     canvas.addEventListener(WI.Canvas.Event.RecordingStarted, handleRecordingStartedWrapper);
                     canvas.addEventListener(WI.Canvas.Event.RecordingStopped, handleRecordingStoppedWrapper);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to