Title: [237745] trunk/Source/_javascript_Core
- Revision
- 237745
- Author
- keith_mil...@apple.com
- Date
- 2018-11-02 12:03:44 -0700 (Fri, 02 Nov 2018)
Log Message
API should use wrapper object if address is 32-bit
https://bugs.webkit.org/show_bug.cgi?id=191203
Reviewed by Filip Pizlo.
* API/APICast.h:
(toJS):
(toJSForGC):
(toRef):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/APICast.h (237744 => 237745)
--- trunk/Source/_javascript_Core/API/APICast.h 2018-11-02 18:31:02 UTC (rev 237744)
+++ trunk/Source/_javascript_Core/API/APICast.h 2018-11-02 19:03:44 UTC (rev 237745)
@@ -69,7 +69,7 @@
inline JSC::JSValue toJS(JSC::ExecState* exec, JSValueRef v)
{
ASSERT_UNUSED(exec, exec);
-#if USE(JSVALUE32_64)
+#if !CPU(ADDRESS64)
JSC::JSCell* jsCell = reinterpret_cast<JSC::JSCell*>(const_cast<OpaqueJSValue*>(v));
if (!jsCell)
return JSC::jsNull();
@@ -91,7 +91,7 @@
inline JSC::JSValue toJSForGC(JSC::ExecState* exec, JSValueRef v)
{
ASSERT_UNUSED(exec, exec);
-#if USE(JSVALUE32_64)
+#if !CPU(ADDRESS64)
JSC::JSCell* jsCell = reinterpret_cast<JSC::JSCell*>(const_cast<OpaqueJSValue*>(v));
if (!jsCell)
return JSC::JSValue();
@@ -131,7 +131,7 @@
inline JSValueRef toRef(JSC::ExecState* exec, JSC::JSValue v)
{
ASSERT(exec->vm().currentThreadIsHoldingAPILock());
-#if USE(JSVALUE32_64)
+#if !CPU(ADDRESS64)
if (!v)
return 0;
if (!v.isCell())
Modified: trunk/Source/_javascript_Core/ChangeLog (237744 => 237745)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-02 18:31:02 UTC (rev 237744)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-02 19:03:44 UTC (rev 237745)
@@ -1,3 +1,15 @@
+2018-11-02 Keith Miller <keith_mil...@apple.com>
+
+ API should use wrapper object if address is 32-bit
+ https://bugs.webkit.org/show_bug.cgi?id=191203
+
+ Reviewed by Filip Pizlo.
+
+ * API/APICast.h:
+ (toJS):
+ (toJSForGC):
+ (toRef):
+
2018-11-02 Tadeu Zagallo <tzaga...@apple.com>
Metadata should not be copyable
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
