Title: [237760] trunk/LayoutTests
- Revision
- 237760
- Author
- cdu...@apple.com
- Date
- 2018-11-02 17:06:09 -0700 (Fri, 02 Nov 2018)
Log Message
REGRESSION (r237699): Layout Test http/tests/security/anchor-download-block-crossorigin.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=191199
Reviewed by Dewei Zhu.
Navigate the subframe instead of the main frame, to make sure that the console message is consistently logged.
* http/tests/security/anchor-download-block-crossorigin-expected.txt:
* http/tests/security/anchor-download-block-crossorigin.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (237759 => 237760)
--- trunk/LayoutTests/ChangeLog 2018-11-02 23:33:24 UTC (rev 237759)
+++ trunk/LayoutTests/ChangeLog 2018-11-03 00:06:09 UTC (rev 237760)
@@ -1,3 +1,15 @@
+2018-11-02 Chris Dumez <cdu...@apple.com>
+
+ REGRESSION (r237699): Layout Test http/tests/security/anchor-download-block-crossorigin.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=191199
+
+ Reviewed by Dewei Zhu.
+
+ Navigate the subframe instead of the main frame, to make sure that the console message is consistently logged.
+
+ * http/tests/security/anchor-download-block-crossorigin-expected.txt:
+ * http/tests/security/anchor-download-block-crossorigin.html:
+
2018-11-02 Per Arne Vollan <pvol...@apple.com>
[Win] Layout Test fast/block/basic/inline-content-with-floating-image.html is failing
Modified: trunk/LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt (237759 => 237760)
--- trunk/LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt 2018-11-02 23:33:24 UTC (rev 237759)
+++ trunk/LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt 2018-11-03 00:06:09 UTC (rev 237760)
@@ -1,2 +1,6 @@
-CONSOLE MESSAGE: line 24: The download attribute on anchor was ignored because its href URL has a different security origin.
-PASS
+CONSOLE MESSAGE: line 25: The download attribute on anchor was ignored because its href URL has a different security origin.
+Tests that the download attribute is ignored if the link is cross origin.
+
+It should navigate the subframe instead of downloading the file.
+
+
Modified: trunk/LayoutTests/http/tests/security/anchor-download-block-crossorigin.html (237759 => 237760)
--- trunk/LayoutTests/http/tests/security/anchor-download-block-crossorigin.html 2018-11-02 23:33:24 UTC (rev 237759)
+++ trunk/LayoutTests/http/tests/security/anchor-download-block-crossorigin.html 2018-11-03 00:06:09 UTC (rev 237760)
@@ -10,9 +10,10 @@
<body>
<p>
Tests that the download attribute is ignored if
-<a id="dl" href="" download="FAIL.pdf">the link</a> is cross origin.
+<a id="dl" href="" download="FAIL.pdf" target="targetFrame">the link</a> is cross origin.
<p>
-It should navigate instead of downloading the file.
+<p>It should navigate the subframe instead of downloading the file.</p>
+<iframe name="targetFrame"></iframe>
<script>
function click(elmt)
{
@@ -29,7 +30,7 @@
var link = document.getElementById("dl");
click(link);
}
- runTest();
+ _onload_ = runTest;
</script>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
