Title: [237793] trunk/Source/_javascript_Core
- Revision
- 237793
- Author
- [email protected]
- Date
- 2018-11-05 01:34:01 -0800 (Mon, 05 Nov 2018)
Log Message
[Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class"
https://bugs.webkit.org/show_bug.cgi?id=191146
Reviewed by Yusuke Suzuki.
* jit/JIT.h: Changed is64BitType from a template class method to a
template inner class.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (237792 => 237793)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-05 09:08:47 UTC (rev 237792)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-05 09:34:01 UTC (rev 237793)
@@ -1,3 +1,13 @@
+2018-11-05 Fujii Hironori <[email protected]>
+
+ [Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class"
+ https://bugs.webkit.org/show_bug.cgi?id=191146
+
+ Reviewed by Yusuke Suzuki.
+
+ * jit/JIT.h: Changed is64BitType from a template class method to a
+ template inner class.
+
2018-11-02 Keith Miller <[email protected]>
Assert JSValues can fit into a pointer when API casting
Modified: trunk/Source/_javascript_Core/jit/JIT.h (237792 => 237793)
--- trunk/Source/_javascript_Core/jit/JIT.h 2018-11-05 09:08:47 UTC (rev 237792)
+++ trunk/Source/_javascript_Core/jit/JIT.h 2018-11-05 09:34:01 UTC (rev 237793)
@@ -781,16 +781,20 @@
}
template<typename Type>
- static constexpr bool is64BitType() { return sizeof(Type) <= 8; }
+ struct is64BitType {
+ static constexpr bool value = sizeof(Type) <= 8;
+ };
template<>
- static constexpr bool is64BitType<void>() { return true; }
+ struct is64BitType<void> {
+ static constexpr bool value = true;
+ };
template<typename OperationType, typename... Args>
std::enable_if_t<!std::is_same<typename FunctionTraits<OperationType>::ResultType, SlowPathReturnType>::value, MacroAssembler::Call>
callOperation(OperationType operation, Args... args)
{
- static_assert(is64BitType<typename FunctionTraits<OperationType>::ResultType>(), "Win64 cannot use standard call when return type is larger than 64 bits.");
+ static_assert(is64BitType<typename FunctionTraits<OperationType>::ResultType>::value, "Win64 cannot use standard call when return type is larger than 64 bits.");
setupArguments<OperationType>(args...);
return appendCallWithExceptionCheck(operation);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
