Title: [237805] trunk/Tools
- Revision
- 237805
- Author
- [email protected]
- Date
- 2018-11-05 08:45:20 -0800 (Mon, 05 Nov 2018)
Log Message
[WPE][GTK] API test runner fails to respect default build type
https://bugs.webkit.org/show_bug.cgi?id=190247
Reviewed by Carlos Garcia Campos.
Problem is it's looking for a release build, even though I've run set-webkit-configuration
--debug. It should look for a debug build unless I explicitly pass --release.
* glib/api_test_runner.py:
(TestRunner.__init__):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (237804 => 237805)
--- trunk/Tools/ChangeLog 2018-11-05 16:08:12 UTC (rev 237804)
+++ trunk/Tools/ChangeLog 2018-11-05 16:45:20 UTC (rev 237805)
@@ -1,3 +1,16 @@
+2018-11-05 Michael Catanzaro <[email protected]>
+
+ [WPE][GTK] API test runner fails to respect default build type
+ https://bugs.webkit.org/show_bug.cgi?id=190247
+
+ Reviewed by Carlos Garcia Campos.
+
+ Problem is it's looking for a release build, even though I've run set-webkit-configuration
+ --debug. It should look for a debug build unless I explicitly pass --release.
+
+ * glib/api_test_runner.py:
+ (TestRunner.__init__):
+
2018-11-05 Thibault Saunier <[email protected]>
[GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
Modified: trunk/Tools/glib/api_test_runner.py (237804 => 237805)
--- trunk/Tools/glib/api_test_runner.py 2018-11-05 16:08:12 UTC (rev 237804)
+++ trunk/Tools/glib/api_test_runner.py 2018-11-05 16:45:20 UTC (rev 237805)
@@ -39,11 +39,17 @@
def __init__(self, port, options, tests=[]):
self._options = options
- self._build_type = "Debug" if self._options.debug else "Release"
- common.set_build_types((self._build_type,))
self._port = Host().port_factory.get(port)
self._driver = self._create_driver()
+ if self._options.debug:
+ self._build_type = "Debug"
+ elif self._options.release:
+ self._build_type = "Release"
+ else:
+ self._build_type = self._port.default_configuration()
+ common.set_build_types((self._build_type,))
+
self._programs_path = common.binary_build_path()
expectations_file = os.path.join(common.top_level_path(), "Tools", "TestWebKitAPI", "glib", "TestExpectations.json")
self._expectations = TestExpectations(self._port.name(), expectations_file, self._build_type)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
