Modified: trunk/Tools/ChangeLog (237821 => 237822)
--- trunk/Tools/ChangeLog 2018-11-05 19:21:36 UTC (rev 237821)
+++ trunk/Tools/ChangeLog 2018-11-05 19:35:47 UTC (rev 237822)
@@ -1,3 +1,19 @@
+2018-11-05 Daniel Bates <[email protected]>
+
+ [lldb-webkit] Fix formatting nits in Document and Frame summary strings
+ https://bugs.webkit.org/show_bug.cgi?id=191094
+
+ Reviewed by Andy Estes.
+
+ Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
+ booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
+ Document summary and add closing brace '}' to both Frame and Document summary strings to make
+ them look pretty.
+
+ * lldb/lldb_webkit.py:
+ (WebCoreFrame_SummaryProvider):
+ (WebCoreDocument_SummaryProvider):
+
2018-11-05 Wenson Hsieh <[email protected]>
[iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
Modified: trunk/Tools/lldb/lldb_webkit.py (237821 => 237822)
--- trunk/Tools/lldb/lldb_webkit.py 2018-11-05 19:21:36 UTC (rev 237821)
+++ trunk/Tools/lldb/lldb_webkit.py 2018-11-05 19:35:47 UTC (rev 237822)
@@ -209,7 +209,7 @@
origin = ''
url = ''
pageCacheState = ''
- return '{ origin = %s, url = "" isMainFrame = %s, pageCacheState = %s' % (origin, url, provider.is_main_frame(), pageCacheState)
+ return '{ origin = %s, url = "" isMainFrame = %d, pageCacheState = %s }' % (origin, url, provider.is_main_frame(), pageCacheState)
def WebCoreDocument_SummaryProvider(valobj, dict):
@@ -216,7 +216,7 @@
provider = WebCoreDocumentProvider(valobj, dict)
frame = provider.frame()
in_main_frame = '%d' % frame.is_main_frame() if frame else 'Detached'
- return '{ origin = %s, url = "" isMainFrame = %s, pageCacheState = %s' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state())
+ return '{ origin = %s, url = "" inMainFrame = %s, pageCacheState = %s }' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state())
def btjs(debugger, command, result, internal_dict):
