Title: [237906] trunk/Source/WebCore
Revision
237906
Author
timo...@apple.com
Date
2018-11-06 17:59:52 -0800 (Tue, 06 Nov 2018)

Log Message

REGRESSION (r237878): css-dark-mode/supported-color-schemes.html is failing on Mojave
https://bugs.webkit.org/show_bug.cgi?id=191338

Reviewed by Dean Jackson.

* page/Page.cpp:
(WebCore::Page::appearanceDidChange): Add back call to didChangeStyleSheetEnvironment().
It was dropped by mistake when I moved code to appearanceDidChange(). This is needed to
update styles for semantic colors and from controls when the media prefers-color-scheme
media query is not used on the page.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (237905 => 237906)


--- trunk/Source/WebCore/ChangeLog	2018-11-07 01:57:39 UTC (rev 237905)
+++ trunk/Source/WebCore/ChangeLog	2018-11-07 01:59:52 UTC (rev 237906)
@@ -1,3 +1,16 @@
+2018-11-06  Timothy Hatcher  <timo...@apple.com>
+
+        REGRESSION (r237878): css-dark-mode/supported-color-schemes.html is failing on Mojave
+        https://bugs.webkit.org/show_bug.cgi?id=191338
+
+        Reviewed by Dean Jackson.
+
+        * page/Page.cpp:
+        (WebCore::Page::appearanceDidChange): Add back call to didChangeStyleSheetEnvironment().
+        It was dropped by mistake when I moved code to appearanceDidChange(). This is needed to
+        update styles for semantic colors and from controls when the media prefers-color-scheme
+        media query is not used on the page.
+
 2018-11-06  Youenn Fablet  <you...@apple.com>
 
         Make mDNS ICE Candidate an experimental flag again

Modified: trunk/Source/WebCore/page/Page.cpp (237905 => 237906)


--- trunk/Source/WebCore/page/Page.cpp	2018-11-07 01:57:39 UTC (rev 237905)
+++ trunk/Source/WebCore/page/Page.cpp	2018-11-07 01:59:52 UTC (rev 237906)
@@ -2462,6 +2462,7 @@
         if (!document)
             continue;
 
+        document->styleScope().didChangeStyleSheetEnvironment();
         document->styleScope().evaluateMediaQueriesForAppearanceChange();
         document->evaluateMediaQueryList();
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to