Title: [237914] trunk/Tools
- Revision
- 237914
- Author
- [email protected]
- Date
- 2018-11-06 21:06:33 -0800 (Tue, 06 Nov 2018)
Log Message
webkitpy: Boot a single worker for custom devices
https://bugs.webkit.org/show_bug.cgi?id=191312
<rdar://problem/45848717>
Rubber-stamped by Aakash Jain.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Custom devices only run a hand-full of tests. Booting multiple
simulators is expensive and unneeded for these tests.
* Scripts/webkitpy/port/ios.py:
(IOSPort. child_processes): No reason to memoize this call, and it prevents
overriding the number of child processes when booting custom devices.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (237913 => 237914)
--- trunk/Tools/ChangeLog 2018-11-07 05:01:30 UTC (rev 237913)
+++ trunk/Tools/ChangeLog 2018-11-07 05:06:33 UTC (rev 237914)
@@ -1,5 +1,20 @@
2018-11-06 Jonathan Bedard <[email protected]>
+ webkitpy: Boot a single worker for custom devices
+ https://bugs.webkit.org/show_bug.cgi?id=191312
+ <rdar://problem/45848717>
+
+ Rubber-stamped by Aakash Jain.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
+ simulators is expensive and unneeded for these tests.
+ * Scripts/webkitpy/port/ios.py:
+ (IOSPort. child_processes): No reason to memoize this call, and it prevents
+ overriding the number of child processes when booting custom devices.
+
+2018-11-06 Jonathan Bedard <[email protected]>
+
webkitpy: Generalize trailing SDK specifier (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=191275
<rdar://problem/45703660>
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (237913 => 237914)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2018-11-07 05:01:30 UTC (rev 237913)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2018-11-07 05:06:33 UTC (rev 237914)
@@ -248,6 +248,8 @@
initial_results, retry_results, enabled_pixel_tests_in_retry = self._run_test_subset(default_device_tests, tests_to_skip)
+ # Only use a single worker for custom device classes
+ self._options.child_processes = 1
for device_class in custom_device_tests:
device_tests = custom_device_tests[device_class]
if device_tests:
Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (237913 => 237914)
--- trunk/Tools/Scripts/webkitpy/port/ios.py 2018-11-07 05:01:30 UTC (rev 237913)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py 2018-11-07 05:06:33 UTC (rev 237914)
@@ -73,7 +73,6 @@
configurations.append(TestConfiguration(version=self.version_name(), architecture=architecture, build_type=build_type))
return configurations
- @memoized
def child_processes(self):
return int(self.get_option('child_processes'))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
