Title: [237917] trunk/Source/WebCore
- Revision
- 237917
- Author
- commit-qu...@webkit.org
- Date
- 2018-11-06 23:32:45 -0800 (Tue, 06 Nov 2018)
Log Message
ServiceWorker Inspector: Uncaught Exception: null is not an object (evaluating 'resource.target.addResource')
https://bugs.webkit.org/show_bug.cgi?id=191339
Patch by Joseph Pecoraro <pecor...@apple.com> on 2018-11-06
Reviewed by Matt Baker.
* workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::fetchScriptWithContext):
Use the Service Worker's identifier, not this static but otherwise unknown identifier.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (237916 => 237917)
--- trunk/Source/WebCore/ChangeLog 2018-11-07 06:05:04 UTC (rev 237916)
+++ trunk/Source/WebCore/ChangeLog 2018-11-07 07:32:45 UTC (rev 237917)
@@ -1,3 +1,14 @@
+2018-11-06 Joseph Pecoraro <pecor...@apple.com>
+
+ ServiceWorker Inspector: Uncaught Exception: null is not an object (evaluating 'resource.target.addResource')
+ https://bugs.webkit.org/show_bug.cgi?id=191339
+
+ Reviewed by Matt Baker.
+
+ * workers/service/ServiceWorkerJob.cpp:
+ (WebCore::ServiceWorkerJob::fetchScriptWithContext):
+ Use the Service Worker's identifier, not this static but otherwise unknown identifier.
+
2018-11-06 Youenn Fablet <you...@apple.com>
sender.replaceTrack() fails with InvalidStateError if the transceiver.direction is "inactive"
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp (237916 => 237917)
--- trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp 2018-11-07 06:05:04 UTC (rev 237916)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp 2018-11-07 07:32:45 UTC (rev 237917)
@@ -95,7 +95,7 @@
m_scriptLoader = WorkerScriptLoader::create();
ResourceRequest request { m_jobData.scriptURL };
- request.setInitiatorIdentifier("serviceWorkerScriptLoad:");
+ request.setInitiatorIdentifier(context.resourceRequestIdentifier());
request.addHTTPHeaderField("Service-Worker"_s, "script"_s);
FetchOptions options;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
