Title: [237960] tags/Safari-607.1.13/Source/_javascript_Core
- Revision
- 237960
- Author
- [email protected]
- Date
- 2018-11-07 17:29:14 -0800 (Wed, 07 Nov 2018)
Log Message
Revert r237734. rdar://problem/45895377
Modified Paths
Diff
Modified: tags/Safari-607.1.13/Source/_javascript_Core/ChangeLog (237959 => 237960)
--- tags/Safari-607.1.13/Source/_javascript_Core/ChangeLog 2018-11-08 01:29:11 UTC (rev 237959)
+++ tags/Safari-607.1.13/Source/_javascript_Core/ChangeLog 2018-11-08 01:29:14 UTC (rev 237960)
@@ -1,5 +1,9 @@
2018-11-07 Alan Coon <[email protected]>
+ Revert r237734. rdar://problem/45895377
+
+2018-11-07 Alan Coon <[email protected]>
+
Revert r237803. rdar://problem/45895377
2018-11-07 Alan Coon <[email protected]>
Modified: tags/Safari-607.1.13/Source/_javascript_Core/bytecode/CodeBlock.cpp (237959 => 237960)
--- tags/Safari-607.1.13/Source/_javascript_Core/bytecode/CodeBlock.cpp 2018-11-08 01:29:11 UTC (rev 237959)
+++ tags/Safari-607.1.13/Source/_javascript_Core/bytecode/CodeBlock.cpp 2018-11-08 01:29:14 UTC (rev 237960)
@@ -1280,7 +1280,7 @@
// Right now this isn't strictly necessary. Any symbol tables that this will refer to
// are for outer functions, and we refer to those functions strongly, and they refer
// to the symbol table strongly. But it's nice to be on the safe side.
- auto& metadata = curInstruction->as<OpResolveScope>().metadata(this);
+ auto metadata = curInstruction->as<OpResolveScope>().metadata(this);
WriteBarrierBase<SymbolTable>& symbolTable = metadata.symbolTable;
if (!symbolTable || Heap::isMarked(symbolTable.get()))
break;
Modified: tags/Safari-607.1.13/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (237959 => 237960)
--- tags/Safari-607.1.13/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2018-11-08 01:29:11 UTC (rev 237959)
+++ tags/Safari-607.1.13/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2018-11-08 01:29:14 UTC (rev 237960)
@@ -4710,7 +4710,7 @@
case op_to_this: {
Node* op1 = getThis();
if (op1->op() != ToThis) {
- auto& metadata = currentInstruction->as<OpToThis>().metadata(codeBlock);
+ auto metadata = currentInstruction->as<OpToThis>().metadata(codeBlock);
Structure* cachedStructure = metadata.cachedStructure.get();
if (metadata.toThisStatus != ToThisOK
|| !cachedStructure
@@ -6163,7 +6163,7 @@
case op_get_from_scope: {
auto bytecode = currentInstruction->as<OpGetFromScope>();
- auto& metadata = bytecode.metadata(codeBlock);
+ auto metadata = bytecode.metadata(codeBlock);
unsigned identifierNumber = m_inlineStackTop->m_identifierRemap[bytecode.var];
UniquedStringImpl* uid = m_graph.identifiers()[identifierNumber];
ResolveType resolveType = metadata.getPutInfo.resolveType();
Modified: tags/Safari-607.1.13/Source/_javascript_Core/generator/Metadata.rb (237959 => 237960)
--- tags/Safari-607.1.13/Source/_javascript_Core/generator/Metadata.rb 2018-11-08 01:29:11 UTC (rev 237959)
+++ tags/Safari-607.1.13/Source/_javascript_Core/generator/Metadata.rb 2018-11-08 01:29:14 UTC (rev 237960)
@@ -63,9 +63,6 @@
<<-EOF
struct Metadata {
- WTF_MAKE_NONCOPYABLE(Metadata);
-
- public:
Metadata(const #{op.capitalized_name}&#{" __op" if inits})
#{inits}
{ }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
