Title: [237982] trunk/Source/WebKit
Revision
237982
Author
[email protected]
Date
2018-11-08 00:28:56 -0800 (Thu, 08 Nov 2018)

Log Message

[GTK] Crash when running with sandbox enabled
https://bugs.webkit.org/show_bug.cgi?id=191353

Reviewed by Michael Catanzaro.

g_key_file_set_string_list() expects a null-terminated array as parameter.

* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::createFlatpakInfo): Append nullptr to sharedPermissions array.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (237981 => 237982)


--- trunk/Source/WebKit/ChangeLog	2018-11-08 05:29:59 UTC (rev 237981)
+++ trunk/Source/WebKit/ChangeLog	2018-11-08 08:28:56 UTC (rev 237982)
@@ -1,3 +1,15 @@
+2018-11-08  Carlos Garcia Campos  <[email protected]>
+
+        [GTK] Crash when running with sandbox enabled
+        https://bugs.webkit.org/show_bug.cgi?id=191353
+
+        Reviewed by Michael Catanzaro.
+
+        g_key_file_set_string_list() expects a null-terminated array as parameter.
+
+        * UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+        (WebKit::createFlatpakInfo): Append nullptr to sharedPermissions array.
+
 2018-11-07  Chris Dumez  <[email protected]>
 
         Unreviewed, fix iOS build with recent SDKs.

Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (237981 => 237982)


--- trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2018-11-08 05:29:59 UTC (rev 237981)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2018-11-08 08:28:56 UTC (rev 237982)
@@ -657,7 +657,7 @@
 {
     GUniquePtr<GKeyFile> keyFile(g_key_file_new());
 
-    const char* sharedPermissions[] = { "network" };
+    const char* sharedPermissions[] = { "network", nullptr };
     g_key_file_set_string_list(keyFile.get(), "Context", "shared", sharedPermissions, sizeof(sharedPermissions));
 
     // xdg-desktop-portal relates your name to certain permissions so we want
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to