Title: [238011] trunk/Source/_javascript_Core
Revision
238011
Author
hironori.fu...@sony.com
Date
2018-11-08 17:29:52 -0800 (Thu, 08 Nov 2018)

Log Message

[Win] UDis86Disassembler.cpp: warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long')
https://bugs.webkit.org/show_bug.cgi?id=191416

Reviewed by Saam Barati.

* disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassembleWithUDis86): Use PRIxPTR for uintptr_t.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (238010 => 238011)


--- trunk/Source/_javascript_Core/ChangeLog	2018-11-09 00:23:24 UTC (rev 238010)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-09 01:29:52 UTC (rev 238011)
@@ -1,3 +1,13 @@
+2018-11-08  Fujii Hironori  <hironori.fu...@sony.com>
+
+        [Win] UDis86Disassembler.cpp: warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long')
+        https://bugs.webkit.org/show_bug.cgi?id=191416
+
+        Reviewed by Saam Barati.
+
+        * disassembler/UDis86Disassembler.cpp:
+        (JSC::tryToDisassembleWithUDis86): Use PRIxPTR for uintptr_t.
+
 2018-11-08  Keith Rollin  <krol...@apple.com>
 
         Create .xcfilelist files

Modified: trunk/Source/_javascript_Core/disassembler/UDis86Disassembler.cpp (238010 => 238011)


--- trunk/Source/_javascript_Core/disassembler/UDis86Disassembler.cpp	2018-11-09 00:23:24 UTC (rev 238010)
+++ trunk/Source/_javascript_Core/disassembler/UDis86Disassembler.cpp	2018-11-09 01:29:52 UTC (rev 238011)
@@ -49,7 +49,7 @@
     uint64_t currentPC = disassembler.pc;
     while (ud_disassemble(&disassembler)) {
         char pcString[20];
-        snprintf(pcString, sizeof(pcString), "0x%lx", static_cast<uintptr_t>(currentPC));
+        snprintf(pcString, sizeof(pcString), "0x%" PRIxPTR, static_cast<uintptr_t>(currentPC));
         out.printf("%s%16s: %s\n", prefix, pcString, ud_insn_asm(&disassembler));
         currentPC = disassembler.pc;
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to