Title: [238017] trunk/Source/WebInspectorUI
- Revision
- 238017
- Author
- [email protected]
- Date
- 2018-11-08 22:07:20 -0800 (Thu, 08 Nov 2018)
Log Message
Uncaught Exception: undefined is not an object (evaluating 'treeElement.parent.removeChild')
https://bugs.webkit.org/show_bug.cgi?id=191454
Patch by Joseph Pecoraro <[email protected]> on 2018-11-08
Reviewed by Matt Baker.
* UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel.prototype._scriptsCleared):
This was intending to iterate the Map's values, which are tree elements.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238016 => 238017)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-09 05:30:48 UTC (rev 238016)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-09 06:07:20 UTC (rev 238017)
@@ -1,5 +1,16 @@
2018-11-08 Joseph Pecoraro <[email protected]>
+ Uncaught Exception: undefined is not an object (evaluating 'treeElement.parent.removeChild')
+ https://bugs.webkit.org/show_bug.cgi?id=191454
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/ResourceSidebarPanel.js:
+ (WI.ResourceSidebarPanel.prototype._scriptsCleared):
+ This was intending to iterate the Map's values, which are tree elements.
+
+2018-11-08 Joseph Pecoraro <[email protected]>
+
Web Inspector: Potential for watch expressions to never show results
https://bugs.webkit.org/show_bug.cgi?id=191438
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js (238016 => 238017)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2018-11-09 05:30:48 UTC (rev 238016)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2018-11-09 06:07:20 UTC (rev 238017)
@@ -413,7 +413,7 @@
}
if (this._targetTreeElementMap.size) {
- for (let treeElement of this._targetTreeElementMap)
+ for (let treeElement of this._targetTreeElementMap.values())
treeElement.parent.removeChild(treeElement, suppressOnDeselect, suppressSelectSibling);
this._targetTreeElementMap.clear();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
