Title: [238030] trunk
- Revision
- 238030
- Author
- carlo...@webkit.org
- Date
- 2018-11-09 08:15:04 -0800 (Fri, 09 Nov 2018)
Log Message
REGRESSION(r236365): [GTK] Many form-related tests are failing
https://bugs.webkit.org/show_bug.cgi?id=189993
Reviewed by Michael Catanzaro.
Source/WebCore:
Only the first form data element is added to the message body due to a return added by mistake in r236365.
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessageBody const): Remove return.
LayoutTests:
Remove expectations for tests that are passing now.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (238029 => 238030)
--- trunk/LayoutTests/ChangeLog 2018-11-09 15:30:43 UTC (rev 238029)
+++ trunk/LayoutTests/ChangeLog 2018-11-09 16:15:04 UTC (rev 238030)
@@ -1,3 +1,14 @@
+2018-11-09 Carlos Garcia Campos <cgar...@igalia.com>
+
+ REGRESSION(r236365): [GTK] Many form-related tests are failing
+ https://bugs.webkit.org/show_bug.cgi?id=189993
+
+ Reviewed by Michael Catanzaro.
+
+ Remove expectations for tests that are passing now.
+
+ * platform/gtk/TestExpectations:
+
2018-11-08 Megan Gardner <megan_gard...@apple.com>
Adopt Reveal Framework to replace Lookup
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (238029 => 238030)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2018-11-09 15:30:43 UTC (rev 238029)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-11-09 16:15:04 UTC (rev 238030)
@@ -3531,11 +3531,6 @@
webkit.org/b/189739 svg/gradients/spreadMethodDiagonal3.svg [ ImageOnlyFailure ]
webkit.org/b/189739 svg/gradients/spreadMethodDiagonal4.svg [ ImageOnlyFailure ]
-webkit.org/b/189993 http/tests/fileapi/xhr-send-form-data-filename-escaping.html [ Failure ]
-webkit.org/b/189993 http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html [ Failure ]
-webkit.org/b/189993 http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html [ Failure ]
-webkit.org/b/189993 http/tests/misc/form-blob-challenge.html [ Failure ]
-
webkit.org/b/189994 fast/files/xhr-response-blob.html [ Failure ]
webkit.org/b/189995 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (238029 => 238030)
--- trunk/Source/WebCore/ChangeLog 2018-11-09 15:30:43 UTC (rev 238029)
+++ trunk/Source/WebCore/ChangeLog 2018-11-09 16:15:04 UTC (rev 238030)
@@ -1,3 +1,15 @@
+2018-11-09 Carlos Garcia Campos <cgar...@igalia.com>
+
+ REGRESSION(r236365): [GTK] Many form-related tests are failing
+ https://bugs.webkit.org/show_bug.cgi?id=189993
+
+ Reviewed by Michael Catanzaro.
+
+ Only the first form data element is added to the message body due to a return added by mistake in r236365.
+
+ * platform/network/soup/ResourceRequestSoup.cpp:
+ (WebCore::ResourceRequest::updateSoupMessageBody const): Remove return.
+
2018-11-09 Zalan Bujtas <za...@apple.com>
[LFC][IFC] Move some code from InlineFormattingContext::Line to InlineFormattingContext/Geometry
Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp (238029 => 238030)
--- trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2018-11-09 15:30:43 UTC (rev 238029)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2018-11-09 16:15:04 UTC (rev 238030)
@@ -74,7 +74,7 @@
soup_message_body_set_accumulate(soupMessage->request_body, FALSE);
uint64_t bodySize = 0;
for (const auto& element : formData->elements()) {
- return switchOn(element.data,
+ switchOn(element.data,
[&] (const Vector<char>& bytes) {
bodySize += bytes.size();
soup_message_body_append(soupMessage->request_body, SOUP_MEMORY_TEMPORARY, bytes.data(), bytes.size());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
