Title: [101790] trunk/Source/WebCore
- Revision
- 101790
- Author
- [email protected]
- Date
- 2011-12-02 06:44:42 -0800 (Fri, 02 Dec 2011)
Log Message
Web Inspector: Split view works weirdly in network panel when resizing, showing/hiding main element.
https://bugs.webkit.org/show_bug.cgi?id=73650
Reviewed by Pavel Feldman.
* inspector/front-end/SplitView.js:
(WebInspector.SplitView.prototype._updateResizer):
(WebInspector.SplitView.prototype.hideMainElement):
(WebInspector.SplitView.prototype.showMainElement):
(WebInspector.SplitView.prototype.onResize):
(WebInspector.SplitView.prototype._restoreSidebarWidth):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101789 => 101790)
--- trunk/Source/WebCore/ChangeLog 2011-12-02 14:15:40 UTC (rev 101789)
+++ trunk/Source/WebCore/ChangeLog 2011-12-02 14:44:42 UTC (rev 101790)
@@ -1,3 +1,17 @@
+2011-12-02 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Split view works weirdly in network panel when resizing, showing/hiding main element.
+ https://bugs.webkit.org/show_bug.cgi?id=73650
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/SplitView.js:
+ (WebInspector.SplitView.prototype._updateResizer):
+ (WebInspector.SplitView.prototype.hideMainElement):
+ (WebInspector.SplitView.prototype.showMainElement):
+ (WebInspector.SplitView.prototype.onResize):
+ (WebInspector.SplitView.prototype._restoreSidebarWidth):
+
2011-12-02 Sheriff Bot <[email protected]>
Unreviewed, rolling out r101783.
Modified: trunk/Source/WebCore/inspector/front-end/SplitView.js (101789 => 101790)
--- trunk/Source/WebCore/inspector/front-end/SplitView.js 2011-12-02 14:15:40 UTC (rev 101789)
+++ trunk/Source/WebCore/inspector/front-end/SplitView.js 2011-12-02 14:44:42 UTC (rev 101790)
@@ -130,7 +130,7 @@
_updateResizer: function()
{
- if (this._resizable)
+ if (this.resizable)
this.sidebarResizerElement.removeStyleClass("hidden");
else
this.sidebarResizerElement.addStyleClass("hidden");
@@ -279,6 +279,12 @@
this.mainElement.addStyleClass("hidden");
this.sidebarElement.addStyleClass("maximized");
+
+ if (this.hasLeftSidebar)
+ this.sidebarElement.style.right = "0px";
+ else
+ this.sidebarElement.style.left = "0px";
+
this._mainElementHidden = true;
this._updateResizer();
this._restoreSidebarWidth();
@@ -291,6 +297,12 @@
this.mainElement.removeStyleClass("hidden");
this.sidebarElement.removeStyleClass("maximized");
+
+ if (this.hasLeftSidebar)
+ this.sidebarElement.style.right = "";
+ else
+ this.sidebarElement.style.left = "";
+
this._mainElementHidden = false;
this._updateResizer();
this._restoreSidebarWidth();
@@ -330,6 +342,9 @@
onResize: function()
{
this._totalWidth = this.element.offsetWidth;
+
+ if (this._mainElementHidden)
+ this._sidebarWidth = this._totalWidth;
},
/**
@@ -390,7 +405,8 @@
_restoreSidebarWidth: function()
{
if (this._mainElementHidden) {
- this._innerSetSidebarWidth(this._totalWidth);
+ this.sidebarElement.style.width = "";
+ this._sidebarWidth = this._totalWidth;
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
