Title: [238254] trunk/Source/WebKit
- Revision
- 238254
- Author
- commit-qu...@webkit.org
- Date
- 2018-11-15 14:42:56 -0800 (Thu, 15 Nov 2018)
Log Message
Web Inspector: Remove unused WebInspectorProxy code
https://bugs.webkit.org/show_bug.cgi?id=191674
Patch by Joseph Pecoraro <pecor...@apple.com> on 2018-11-15
Reviewed by Dean Jackson.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::closeFrontendPageAndWindow):
* UIProcess/WebInspectorProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::setInspectorWindowFrame): Deleted.
(WebKit::WebInspectorProxy::inspectorWindowFrame): Deleted.
* WebProcess/WebPage/WebInspector.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (238253 => 238254)
--- trunk/Source/WebKit/ChangeLog 2018-11-15 22:38:39 UTC (rev 238253)
+++ trunk/Source/WebKit/ChangeLog 2018-11-15 22:42:56 UTC (rev 238254)
@@ -1,3 +1,19 @@
+2018-11-15 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Remove unused WebInspectorProxy code
+ https://bugs.webkit.org/show_bug.cgi?id=191674
+
+ Reviewed by Dean Jackson.
+
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::createInspectorPage):
+ (WebKit::WebInspectorProxy::closeFrontendPageAndWindow):
+ * UIProcess/WebInspectorProxy.h:
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (WebKit::WebInspectorProxy::setInspectorWindowFrame): Deleted.
+ (WebKit::WebInspectorProxy::inspectorWindowFrame): Deleted.
+ * WebProcess/WebPage/WebInspector.h:
+
2018-11-15 Ryosuke Niwa <rn...@webkit.org>
Enable process swap on cross-site navigation by default on macOS
Modified: trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp (238253 => 238254)
--- trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp 2018-11-15 22:38:39 UTC (rev 238253)
+++ trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp 2018-11-15 22:42:56 UTC (rev 238254)
@@ -353,10 +353,8 @@
if (!m_inspectorPage)
return;
- m_connectionIdentifier = WTFMove(connectionIdentifier);
+ m_inspectorPage->process().send(Messages::WebInspectorUI::EstablishConnection(WTFMove(connectionIdentifier), m_inspectedPage->pageID(), m_underTest, inspectionLevel()), m_inspectorPage->pageID());
- m_inspectorPage->process().send(Messages::WebInspectorUI::EstablishConnection(m_connectionIdentifier, m_inspectedPage->pageID(), m_underTest, inspectionLevel()), m_inspectorPage->pageID());
-
if (!m_underTest) {
m_canAttach = platformCanAttach(canAttach);
m_isAttached = shouldOpenAttached();
@@ -437,8 +435,6 @@
m_canAttach = false;
m_underTest = false;
- m_connectionIdentifier = IPC::Attachment();
-
platformCloseFrontendPageAndWindow();
}
Modified: trunk/Source/WebKit/UIProcess/WebInspectorProxy.h (238253 => 238254)
--- trunk/Source/WebKit/UIProcess/WebInspectorProxy.h 2018-11-15 22:38:39 UTC (rev 238253)
+++ trunk/Source/WebKit/UIProcess/WebInspectorProxy.h 2018-11-15 22:42:56 UTC (rev 238254)
@@ -107,9 +107,6 @@
void windowFullScreenDidChange();
NSWindow* inspectorWindow() const { return m_inspectorWindow.get(); }
- void setInspectorWindowFrame(WKRect&);
- WKRect inspectorWindowFrame();
-
void closeFrontendPage();
void closeFrontendAfterInactivityTimerFired();
@@ -243,8 +240,6 @@
bool m_ignoreElementSelectionChange { false };
bool m_isOpening { false };
- IPC::Attachment m_connectionIdentifier;
-
AttachmentSide m_attachmentSide {AttachmentSide::Bottom};
#if PLATFORM(MAC) && WK_API_ENABLED
Modified: trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm (238253 => 238254)
--- trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm 2018-11-15 22:38:39 UTC (rev 238253)
+++ trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm 2018-11-15 22:42:56 UTC (rev 238254)
@@ -210,23 +210,6 @@
}
}
-void WebInspectorProxy::setInspectorWindowFrame(WKRect& frame)
-{
- if (m_isAttached)
- return;
-
- [m_inspectorWindow setFrame:NSMakeRect(frame.origin.x, frame.origin.y, frame.size.width, frame.size.height) display:YES];
-}
-
-WKRect WebInspectorProxy::inspectorWindowFrame()
-{
- if (m_isAttached)
- return WKRectMake(0, 0, 0, 0);
-
- NSRect frame = m_inspectorWindow.get().frame;
- return WKRectMake(frame.origin.x, frame.origin.y, frame.size.width, frame.size.height);
-}
-
void WebInspectorProxy::updateInspectorWindowTitle() const
{
if (!m_inspectorWindow)
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebInspector.h (238253 => 238254)
--- trunk/Source/WebKit/WebProcess/WebPage/WebInspector.h 2018-11-15 22:38:39 UTC (rev 238253)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebInspector.h 2018-11-15 22:42:56 UTC (rev 238254)
@@ -54,9 +54,6 @@
void didClose(IPC::Connection&) override { close(); }
void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference) override { close(); }
- // Called by WebInspector messages
- void connectionEstablished();
-
void show();
void close();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
