Title: [238305] trunk/Source/WebInspectorUI
- Revision
- 238305
- Author
- [email protected]
- Date
- 2018-11-16 14:45:13 -0800 (Fri, 16 Nov 2018)
Log Message
Web Inspector: TreeOutline shouldn't select first child of an expanded element on right arrow key
https://bugs.webkit.org/show_bug.cgi?id=191766
Reviewed by Devin Rousso.
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._treeKeyDown):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238304 => 238305)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-16 22:16:34 UTC (rev 238304)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-16 22:45:13 UTC (rev 238305)
@@ -1,3 +1,13 @@
+2018-11-16 Matt Baker <[email protected]>
+
+ Web Inspector: TreeOutline shouldn't select first child of an expanded element on right arrow key
+ https://bugs.webkit.org/show_bug.cgi?id=191766
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype._treeKeyDown):
+
2018-11-14 Matt Baker <[email protected]>
Web Inspector: Table should recalculate scrollable height when resized
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (238304 => 238305)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2018-11-16 22:16:34 UTC (rev 238304)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2018-11-16 22:45:13 UTC (rev 238305)
@@ -563,12 +563,7 @@
handled = true;
} else if (this.selectedTreeElement.hasChildren) {
handled = true;
- if (this.selectedTreeElement.expanded) {
- nextSelectedElement = this.selectedTreeElement.children[0];
- while (nextSelectedElement && !nextSelectedElement.selectable)
- nextSelectedElement = nextSelectedElement.nextSibling;
- handled = nextSelectedElement ? true : false;
- } else {
+ if (!this.selectedTreeElement.expanded) {
if (event.altKey)
this.selectedTreeElement.expandRecursively();
else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
