Title: [238323] trunk/Tools
Revision
238323
Author
cdu...@apple.com
Date
2018-11-16 16:17:32 -0800 (Fri, 16 Nov 2018)

Log Message

Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
https://bugs.webkit.org/show_bug.cgi?id=191789

Reviewed by Alex Christensen.

Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
SPI no longer works with PSON / Process prewarming.

* TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (238322 => 238323)


--- trunk/Tools/ChangeLog	2018-11-17 00:15:55 UTC (rev 238322)
+++ trunk/Tools/ChangeLog	2018-11-17 00:17:32 UTC (rev 238323)
@@ -1,3 +1,16 @@
+2018-11-16  Chris Dumez  <cdu...@apple.com>
+
+        Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=191789
+
+        Reviewed by Alex Christensen.
+
+        Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
+        SPI no longer works with PSON / Process prewarming.
+
+        * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
+        (TestWebKitAPI::TEST):
+
 2018-11-16  Jonathan Bedard  <jbed...@apple.com>
 
         webkitpy: Retry app installation on watchOS simulators

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/Geolocation.cpp (238322 => 238323)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit/Geolocation.cpp	2018-11-17 00:15:55 UTC (rev 238322)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/Geolocation.cpp	2018-11-17 00:17:32 UTC (rev 238323)
@@ -257,7 +257,6 @@
 TEST(WebKit, GeolocationTransitionToHighAccuracy)
 {
     WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());
-    WKContextSetMaximumNumberOfProcesses(context.get(), 1);
 
     GeolocationTransitionToHighAccuracyStateTracker stateTracker;
     setupGeolocationProvider(context.get(), &stateTracker);
@@ -268,7 +267,7 @@
     WKPageLoadURL(lowAccuracyWebView.page(), lowAccuracyURL.get());
     Util::run(&stateTracker.finishedFirstStep);
 
-    PlatformWebView highAccuracyWebView(context.get());
+    PlatformWebView highAccuracyWebView(lowAccuracyWebView.page());
     setupView(highAccuracyWebView);
     WKRetainPtr<WKURLRef> highAccuracyURL(AdoptWK, Util::createURLForResource("geolocationWatchPositionWithHighAccuracy", "html"));
     WKPageLoadURL(highAccuracyWebView.page(), highAccuracyURL.get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to