Title: [238444] trunk/Tools
- Revision
- 238444
- Author
- [email protected]
- Date
- 2018-11-22 04:53:39 -0800 (Thu, 22 Nov 2018)
Log Message
[Flatpak] Do not disable signals when running "usual" commands
https://bugs.webkit.org/show_bug.cgi?id=190679
Patch by Thibault Saunier <[email protected]> on 2018-11-22
Reviewed by Philippe Normand.
Otherwise <ctr>c doesn't work while compiling. It is not the best fix
as there are cases we want to let only children receive signals, but
it is not clear how to determine when (when running gdb, we still
disable those).
* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (238443 => 238444)
--- trunk/Tools/ChangeLog 2018-11-22 09:59:33 UTC (rev 238443)
+++ trunk/Tools/ChangeLog 2018-11-22 12:53:39 UTC (rev 238444)
@@ -1,3 +1,18 @@
+2018-11-22 Thibault Saunier <[email protected]>
+
+ [Flatpak] Do not disable signals when running "usual" commands
+ https://bugs.webkit.org/show_bug.cgi?id=190679
+
+ Reviewed by Philippe Normand.
+
+ Otherwise <ctr>c doesn't work while compiling. It is not the best fix
+ as there are cases we want to let only children receive signals, but
+ it is not clear how to determine when (when running gdb, we still
+ disable those).
+
+ * flatpak/flatpakutils.py:
+ (WebkitFlatpak.run_in_sandbox):
+
2018-11-21 Wenson Hsieh <[email protected]>
[Cocoa] [WebKit2] Add support for replacing find-in-page text matches
Modified: trunk/Tools/flatpak/flatpakutils.py (238443 => 238444)
--- trunk/Tools/flatpak/flatpakutils.py 2018-11-22 09:59:33 UTC (rev 238443)
+++ trunk/Tools/flatpak/flatpakutils.py 2018-11-22 12:53:39 UTC (rev 238444)
@@ -746,12 +746,11 @@
_log.debug('Running in sandbox: "%s" %s\n' % ('" "'.join(flatpak_command), shell_string))
flatpak_command.extend(['sh', "/run/host/" + tmpscript.name])
- with disable_signals():
- try:
- subprocess.check_call(flatpak_command, stdout=stdout)
- except subprocess.CalledProcessError as e:
- sys.stderr.write(str(e) + "\n")
- return e.returncode
+ try:
+ subprocess.check_call(flatpak_command, stdout=stdout)
+ except subprocess.CalledProcessError as e:
+ sys.stderr.write(str(e) + "\n")
+ return e.returncode
return 0
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
