Title: [238450] trunk/LayoutTests
- Revision
- 238450
- Author
- [email protected]
- Date
- 2018-11-22 12:32:52 -0800 (Thu, 22 Nov 2018)
Log Message
Improve fast/scrolling/scrolling-tree-includes-frame.html
https://bugs.webkit.org/show_bug.cgi?id=191912
These are small improvements to scrolling-tree-includes-frame.html:
- Run doTest() after the iframe is loaded and use waitUntilDone/notifyDone for more reliable timing.
- Use iframe@srcdoc instead of iframe@src and put the content of the iframe document in its own line.
- Move the iframe style in a separate <style> tag and ensure the iframe is really positioned at (0,0)
with no extra margin/padding/border.
- Remove unnecessary id="frame"
The test expectation is not changed.
Patch by Frederic Wang <[email protected]> on 2018-11-22
Reviewed by Antonio Gomes.
* fast/scrolling/scrolling-tree-includes-frame.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (238449 => 238450)
--- trunk/LayoutTests/ChangeLog 2018-11-22 18:56:28 UTC (rev 238449)
+++ trunk/LayoutTests/ChangeLog 2018-11-22 20:32:52 UTC (rev 238450)
@@ -1,3 +1,20 @@
+2018-11-22 Frederic Wang <[email protected]>
+
+ Improve fast/scrolling/scrolling-tree-includes-frame.html
+ https://bugs.webkit.org/show_bug.cgi?id=191912
+
+ These are small improvements to scrolling-tree-includes-frame.html:
+ - Run doTest() after the iframe is loaded and use waitUntilDone/notifyDone for more reliable timing.
+ - Use iframe@srcdoc instead of iframe@src and put the content of the iframe document in its own line.
+ - Move the iframe style in a separate <style> tag and ensure the iframe is really positioned at (0,0)
+ with no extra margin/padding/border.
+ - Remove unnecessary id="frame"
+ The test expectation is not changed.
+
+ Reviewed by Antonio Gomes.
+
+ * fast/scrolling/scrolling-tree-includes-frame.html:
+
2018-11-22 Zalan Bujtas <[email protected]>
[LFC][IFC] Offset formatting context root runs with horizontal margins.
Modified: trunk/LayoutTests/fast/scrolling/scrolling-tree-includes-frame.html (238449 => 238450)
--- trunk/LayoutTests/fast/scrolling/scrolling-tree-includes-frame.html 2018-11-22 18:56:28 UTC (rev 238449)
+++ trunk/LayoutTests/fast/scrolling/scrolling-tree-includes-frame.html 2018-11-22 20:32:52 UTC (rev 238450)
@@ -3,8 +3,10 @@
<head>
<title>Check whether scrollable iframes are included in the scrolling tree when async frame scrolling is enabled</title>
<script>
- if (window.testRunner)
+ if (window.testRunner) {
testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
if (window.internals)
window.internals.settings.setAsyncFrameScrollingEnabled(true);
function doTest()
@@ -11,12 +13,27 @@
{
if (window.internals)
document.getElementById('scrollingTree').innerText = window.internals.scrollingStateTreeAsText() + "\n";
+ if (window.testRunner)
+ testRunner.notifyDone();
}
- window.addEventListener('load', doTest, false);
</script>
+ <style>
+ iframe {
+ position: absolute;
+ left: 0;
+ top: 0;
+ width: 100px;
+ height: 200px;
+ margin: 0;
+ border: 0;
+ padding: 0;
+ }
+ </style>
</head>
<body>
- <iframe id="frame" style="width: 100px; height: 200px; border: 1px solid black;" src="" style='width: 300px; height: 400px; background: gray;'></div>"></iframe>
+ <iframe _onload_="doTest()" srcdoc="
+ <div style='width: 300px; height: 400px; background: gray;'></div>">
+ </iframe>
<pre id="scrollingTree"></pre>
</body>
</html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
