Title: [238462] trunk/Source/WebCore
- Revision
- 238462
- Author
- [email protected]
- Date
- 2018-11-23 11:45:52 -0800 (Fri, 23 Nov 2018)
Log Message
[GTK] Scrollbars not following gtk-primary-button-warps-slider setting
https://bugs.webkit.org/show_bug.cgi?id=191067
Updated code per the style guide, removed unreachable break (non-semantic change)
Patch by Jim Mason <[email protected]> on 2018-11-23
Reviewed by Michael Catanzaro.
* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::handleMousePressEvent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (238461 => 238462)
--- trunk/Source/WebCore/ChangeLog 2018-11-23 18:18:01 UTC (rev 238461)
+++ trunk/Source/WebCore/ChangeLog 2018-11-23 19:45:52 UTC (rev 238462)
@@ -1,3 +1,15 @@
+2018-11-23 Jim Mason <[email protected]>
+
+ [GTK] Scrollbars not following gtk-primary-button-warps-slider setting
+ https://bugs.webkit.org/show_bug.cgi?id=191067
+
+ Updated code per the style guide, removed unreachable break (non-semantic change)
+
+ Reviewed by Michael Catanzaro.
+
+ * platform/gtk/ScrollbarThemeGtk.cpp:
+ (WebCore::ScrollbarThemeGtk::handleMousePressEvent):
+
2018-11-23 Wenson Hsieh <[email protected]>
Enable drag and drop support for iOSMac
Modified: trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp (238461 => 238462)
--- trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp 2018-11-23 18:18:01 UTC (rev 238461)
+++ trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp 2018-11-23 19:45:52 UTC (rev 238462)
@@ -772,20 +772,19 @@
ScrollbarButtonPressAction ScrollbarThemeGtk::handleMousePressEvent(Scrollbar&, const PlatformMouseEvent& event, ScrollbarPart pressedPart)
{
- gboolean warp_slider = FALSE;
+ gboolean warpSlider = FALSE;
switch (pressedPart) {
case BackTrackPart:
case ForwardTrackPart:
g_object_get(gtk_settings_get_default(),
"gtk-primary-button-warps-slider",
- &warp_slider, nullptr);
+ &warpSlider, nullptr);
// The shift key or middle/right button reverses the sense.
if (event.shiftKey() || event.button() != LeftButton)
- warp_slider = !warp_slider;
- return warp_slider ?
+ warpSlider = !warpSlider;
+ return warpSlider ?
ScrollbarButtonPressAction::CenterOnThumb:
ScrollbarButtonPressAction::Scroll;
- break;
case ThumbPart:
if (event.button() != RightButton)
return ScrollbarButtonPressAction::StartDrag;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
