Title: [238516] trunk/Source/WebCore
- Revision
- 238516
- Author
- [email protected]
- Date
- 2018-11-26 13:19:52 -0800 (Mon, 26 Nov 2018)
Log Message
Picture-in-picture window size changes unnecesarily when URL changes.
https://bugs.webkit.org/show_bug.cgi?id=191787
Patch by Jeremy Jones <[email protected]> on 2018-11-26
Reviewed by Jer Noble.
When loading a new URL, the video dimensions are temporarily 0,0. Instead of
defaulting back to 4:3 sized pip window temporarily, keep the old dimensions until
there is a new valid size.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::videoDimensionsChanged):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (238515 => 238516)
--- trunk/Source/WebCore/ChangeLog 2018-11-26 21:13:47 UTC (rev 238515)
+++ trunk/Source/WebCore/ChangeLog 2018-11-26 21:19:52 UTC (rev 238516)
@@ -1,3 +1,17 @@
+2018-11-26 Jeremy Jones <[email protected]>
+
+ Picture-in-picture window size changes unnecesarily when URL changes.
+ https://bugs.webkit.org/show_bug.cgi?id=191787
+
+ Reviewed by Jer Noble.
+
+ When loading a new URL, the video dimensions are temporarily 0,0. Instead of
+ defaulting back to 4:3 sized pip window temporarily, keep the old dimensions until
+ there is a new valid size.
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+ (VideoFullscreenInterfaceAVKit::videoDimensionsChanged):
+
2018-11-26 Andy Estes <[email protected]>
[Cocoa] Make it easier to encode NSObjects
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (238515 => 238516)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2018-11-26 21:13:47 UTC (rev 238515)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2018-11-26 21:19:52 UTC (rev 238516)
@@ -784,6 +784,9 @@
void VideoFullscreenInterfaceAVKit::videoDimensionsChanged(const FloatSize& videoDimensions)
{
+ if (videoDimensions.isZero())
+ return;
+
WebAVPlayerLayer *playerLayer = (WebAVPlayerLayer *)[m_playerLayerView playerLayer];
[playerLayer setVideoDimensions:videoDimensions];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
