Title: [238534] trunk/Tools
- Revision
- 238534
- Author
- [email protected]
- Date
- 2018-11-26 17:02:42 -0800 (Mon, 26 Nov 2018)
Log Message
webkitpy: Race condition in ServerProcess tests
https://bugs.webkit.org/show_bug.cgi?id=191989
<rdar://problem/45536844>
Reviewed by Lucas Forschler.
Serializing these tests to prevent the race conditions.
* Scripts/webkitpy/port/server_process_unittest.py:
(TestServerProcess.serial_test_basic):
(TestServerProcess.serial_test_read_after_process_exits):
(TestServerProcess.serial_test_process_crashing):
(TestServerProcess.serial_test_process_crashing_no_data):
(TestServerProcess.test_basic): Deleted.
(TestServerProcess.test_read_after_process_exits): Deleted.
(TestServerProcess.test_process_crashing): Deleted.
(TestServerProcess.test_process_crashing_no_data): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (238533 => 238534)
--- trunk/Tools/ChangeLog 2018-11-27 00:57:34 UTC (rev 238533)
+++ trunk/Tools/ChangeLog 2018-11-27 01:02:42 UTC (rev 238534)
@@ -1,3 +1,23 @@
+2018-11-26 Jonathan Bedard <[email protected]>
+
+ webkitpy: Race condition in ServerProcess tests
+ https://bugs.webkit.org/show_bug.cgi?id=191989
+ <rdar://problem/45536844>
+
+ Reviewed by Lucas Forschler.
+
+ Serializing these tests to prevent the race conditions.
+
+ * Scripts/webkitpy/port/server_process_unittest.py:
+ (TestServerProcess.serial_test_basic):
+ (TestServerProcess.serial_test_read_after_process_exits):
+ (TestServerProcess.serial_test_process_crashing):
+ (TestServerProcess.serial_test_process_crashing_no_data):
+ (TestServerProcess.test_basic): Deleted.
+ (TestServerProcess.test_read_after_process_exits): Deleted.
+ (TestServerProcess.test_process_crashing): Deleted.
+ (TestServerProcess.test_process_crashing_no_data): Deleted.
+
2018-11-26 Aakash Jain <[email protected]>
[ews-app] Add field in Patch object to indicate if it has been sent to Buildbot
Modified: trunk/Tools/Scripts/webkitpy/port/server_process_unittest.py (238533 => 238534)
--- trunk/Tools/Scripts/webkitpy/port/server_process_unittest.py 2018-11-27 00:57:34 UTC (rev 238533)
+++ trunk/Tools/Scripts/webkitpy/port/server_process_unittest.py 2018-11-27 01:02:42 UTC (rev 238534)
@@ -98,7 +98,7 @@
class TestServerProcess(unittest.TestCase):
- def test_basic(self):
+ def serial_test_basic(self):
# Give -u switch to force stdout and stderr to be unbuffered for Windows
cmd = [sys.executable, '-uc', 'import sys; print "stdout"; print >>sys.stderr, "stderr"; sys.stdin.readline();']
host = SystemHost()
@@ -128,7 +128,7 @@
proc.stop(0)
- def test_read_after_process_exits(self):
+ def serial_test_read_after_process_exits(self):
cmd = [sys.executable, '-c', 'import sys; print "stdout"; print >>sys.stderr, "stderr";']
host = SystemHost()
factory = PortFactory(host)
@@ -146,7 +146,7 @@
proc.stop(0)
- def test_process_crashing(self):
+ def serial_test_process_crashing(self):
# Give -u switch to force stdout to be unbuffered for Windows
cmd = [sys.executable, '-uc', 'import sys; print "stdout 1"; print "stdout 2"; print "stdout 3"; sys.stdin.readline(); sys.exit(1);']
host = SystemHost()
@@ -172,7 +172,7 @@
proc.stop(0)
- def test_process_crashing_no_data(self):
+ def serial_test_process_crashing_no_data(self):
cmd = [sys.executable, '-c',
'import sys; sys.stdin.readline(); sys.exit(1);']
host = SystemHost()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
